New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Implement CSV export #1030

Merged

DanailH merged 33 commits into mui:master from DanailH:feature/DataGrid-197-csv-export

Feb 19, 2021

Member

DanailH commented Feb 11, 2021 •

edited by oliviertassinari

Loading

Fixes #197

This is a draft, for now, to iron out the implementation but this initial version is stable and can be tested.

Let's use it to discuss the UI, the functionality, and the API.

ToDo:

Add tests
Add docs
Add translations

DanailH added 2 commits

February 11, 2021 12:43


          Finish setup

f16ca59


          First stable draft version

548a417

DanailH added component: data grid new feature labels

DanailH requested review from dtassone and oliviertassinari

February 11, 2021 13:47

DanailH self-assigned this

DanailH added 2 commits

February 11, 2021 14:49


          Resolve conflicts

3752bb0


          Remove unneded prop from new story

1760a62

dtassone reviewed

View reviewed changes

packages/grid/_modules_/grid/components/toolbar/DensitySelector.tsx Outdated Show resolved Hide resolved

dtassone reviewed

View reviewed changes

packages/grid/_modules_/grid/components/toolbar/ExportSelector.tsx Outdated Show resolved Hide resolved

oliviertassinari reviewed

View reviewed changes

packages/grid/_modules_/grid/hooks/features/export/useCsvExport.tsx Outdated Show resolved Hide resolved

oliviertassinari reviewed

View reviewed changes

packages/grid/_modules_/grid/models/api/csvExportApi.ts Outdated Show resolved Hide resolved

oliviertassinari reviewed

View reviewed changes

packages/grid/_modules_/grid/models/gridIconSlotsComponent.ts Outdated Show resolved Hide resolved

oliviertassinari reviewed

View reviewed changes

packages/grid/_modules_/grid/models/gridOptions.tsx Outdated Show resolved Hide resolved

oliviertassinari reviewed

View reviewed changes

packages/grid/_modules_/grid/utils/exportAs.ts Outdated Show resolved Hide resolved

oliviertassinari reviewed

View reviewed changes

Member

oliviertassinari left a comment

For the tests, I think that one for the output of getDataAsCsv would be enough, I'm not sure we need more

DanailH added 11 commits

February 12, 2021 11:33


          Make getLocalization helper accept partial translations

57da33b

wip

d5ccdbc


          Fix typings

7ae1326


          Rework exportAs util


          Get latest changes

258a427


          Fix formatting

37c11db


          Remove commented out code

835ee07


          Update return type

55caa1b


          Add docs

5f5c10a


          Add test

b538322


          Fix accessibility on density selector and export selector

ff07421

DanailH marked this pull request as ready for review

February 12, 2021 14:02

DanailH requested a review from mbrookes

February 12, 2021 14:02

DanailH and others added 6 commits

February 12, 2021 15:59


          Update packages/grid/_modules_/grid/models/api/localeTextApi.ts

213a173

Co-authored-by: Olivier Tassinari <[email protected]>


          Update packages/grid/_modules_/grid/constants/localeTextConstants.ts

1e10f5d

Co-authored-by: Olivier Tassinari <[email protected]>


          Update packages/grid/_modules_/grid/components/toolbar/ExportSelector…

a905d9e

….tsx

Co-authored-by: Olivier Tassinari <[email protected]>


          Fix PR comments

b4783f1


          Update docs

fa8fef7


          Fix focus issue for GridMenu

6e096e7

oliviertassinari self-requested a review

February 15, 2021 13:20


          remove ids and labledby for now

26dfc1b

DanailH mentioned this pull request

[docs] Remove under construction icons from DataGrid feature pages mui/material-ui#24946

Merged

1 task

oliviertassinari requested changes

View reviewed changes

packages/grid/_modules_/grid/components/menu/GridMenu.tsx Show resolved Hide resolved

packages/grid/_modules_/grid/components/menu/GridMenu.tsx Outdated Show resolved Hide resolved

packages/grid/_modules_/grid/components/toolbar/DensitySelector.tsx Outdated Show resolved Hide resolved

packages/grid/_modules_/grid/components/toolbar/GridToolbarExport.tsx Outdated Show resolved Hide resolved

packages/grid/_modules_/grid/models/gridOptions.tsx Outdated Show resolved Hide resolved

DanailH added 2 commits

February 15, 2021 17:20


          Fix PR comments


          Fix formatting

e7f0bfa

dtassone reviewed

View reviewed changes

packages/grid/_modules_/grid/components/toolbar/GridToolbarExport.tsx Show resolved Hide resolved

dtassone reviewed

View reviewed changes

packages/grid/_modules_/grid/components/toolbar/GridToolbarExport.tsx Outdated Show resolved Hide resolved

dtassone reviewed

View reviewed changes

packages/grid/_modules_/grid/hooks/features/export/useCsvExport.tsx Outdated Show resolved Hide resolved

dtassone reviewed

View reviewed changes

packages/grid/_modules_/grid/hooks/features/export/useCsvExport.tsx Outdated Show resolved Hide resolved

DanailH and others added 3 commits

February 16, 2021 10:01


          Remove new grid prop

40e7991


          Trigger Build


          give a try without the div, it works, it will also help catch wrong u…

f9df9b8

…sage

oliviertassinari approved these changes

View reviewed changes


          fix my typo, use prev to give more semantic to what the ref is about

89b0b72

DanailH requested a review from dtassone

February 17, 2021 09:36

DanailH added 2 commits

February 18, 2021 14:43


          abstract logic and rename api

4f8c602


          Merge branch 'feature/DataGrid-197-csv-export' of github.com:DanailH/…

b5b26ba

…material-ui-x into feature/DataGrid-197-csv-export

dtassone approved these changes

View reviewed changes

DanailH added 2 commits

February 19, 2021 11:34


          Resolve conflicts

f27af51


          Fix tests

30488c1

DanailH merged commit 981433a into mui:master

oliviertassinari mentioned this pull request

[DataGrid] Improve ptBR locale #1861

Merged

oliviertassinari mentioned this pull request

[docs] Allow linking icons state in the URL mui/material-ui#25053

Closed

1 task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: data grid new feature