[DataGrid] Handle special chars when doing CSV export

[DanailH]

Fixes #1143

[oliviertassinari]

• How about we add a test case that reproduce the issue? I think that we can test the function in isolatation. No need to mount the grid component.
• What happens if there a double quote in the cell we are exporting? See http://www.creativyst.com/Doc/Articles/CSV/CSV01.htm#FileFormat
• Should we only add the " if there is a comma in order to save space in the CSV export?

[oliviertassinari]

Regarding the tests, I think that we can improve them:

1. Only test the CSV exporter without the data grid. We will need to the same for the Excel exported.
2. Cover edge cases you have considered but aren't tested. e.g. " inside the value of one cell.

What do you think?

[oliviertassinari]

Things I would have done differently if I was working on this:

• In the tests, I would have used 2-dimensional data. Note one row, nor one column, but at least two columns and rows.
• I would have split the problem into two phases. One phase about constructing the 2d data structure for export. And a second phase to convert this 2d structure into a CSV. Hopefully, this would bring two values. I suspect that the first phase would be shared with the Excel export. I also assume that it would allow, in the future to write unit tests that run much faster for covering more formatting edge-cases and more formating options, like custom delimiters.

[z0d14c]

I started using mui x datagrid well after this was merged (end of 2023) and I still see the issue... I'm just curious what is the best way to check if the commit is in the version of mui x I'm using?

[z0d14c]

On v6.16.0, I'm not seeing anything when I search git log --all --grep="82f3d84" ...

[z0d14c]

hmm, nevermind, I found it by searching for the content of the commit:

commit 82f3d84
Author: Danail Hadjiatanasov [email protected]
Date: Mon Mar 8 17:14:56 2021 +0100

[DataGrid] Handle special chars when doing CSV export (#1154)

wonder why it isn't working -- we're still seeing screwed up exports when we have values with commas in them