-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataGrid] Improve ptBR locale #1861
Conversation
Export translation
How about we use this opportunity to add the same keys commented in the other locales? It will make it easier for the other translators to handle. |
@oliviertassinari Side note: the |
Co-authored-by: Matheus Wichman <[email protected]>
@m4theushw Great 👁️ for the details! It was added in #1030, maybe it was refactored and forgot along the way. In this case, no need to translate it. |
@m4theushw Actually, it depends, It looks like @DanailH added it so that a button can have a label if only the icon is visible. 👍 for a new issue/a follow-up to make this consistent between the different toolbar buttons. I would personally argue that for the only icon use case, https://next.material-ui.com/system/screen-readers/#visually-hidden-elements has the potential to be more elegant. Less code, fewer translations. But If we want to make it work in a responsive way (hide the label on small screens), it might not fly. |
Add missing export translations.