Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Improve ptBR locale #1861

Merged
merged 6 commits into from
Jun 10, 2021
Merged

[DataGrid] Improve ptBR locale #1861

merged 6 commits into from
Jun 10, 2021

Conversation

aline-matos
Copy link
Contributor

@aline-matos aline-matos commented Jun 9, 2021

Add missing export translations.

Export translation
@oliviertassinari
Copy link
Member

How about we use this opportunity to add the same keys commented in the other locales?

https://github.com/mui-org/material-ui-x/blob/f5221ef2a1b4345c244cfc3704de67b39472e54a/packages/grid/_modules_/grid/constants/localeTextConstants.ts#L28-L31

It will make it easier for the other translators to handle.

@oliviertassinari oliviertassinari added component: data grid This is the name of the generic UI component, not the React module! new feature New feature or request labels Jun 9, 2021
@oliviertassinari oliviertassinari changed the title Update ptBR.ts [DataGrid] Improve ptBR locale Jun 9, 2021
@m4theushw
Copy link
Member

@oliviertassinari Side note: the toolbarExportLabel key is not used. We could remove it from the other locales in another PR.

@oliviertassinari
Copy link
Member

Side note: the toolbarExportLabel key is not used. We could remove it from the other locales in another PR.

@m4theushw Great 👁️ for the details! It was added in #1030, maybe it was refactored and forgot along the way. In this case, no need to translate it.

@oliviertassinari
Copy link
Member

oliviertassinari commented Jun 9, 2021

maybe it was refactored and forgot along the way. In this case, no need to translate it.

@m4theushw Actually, it depends, It looks like @DanailH added it so that a button can have a label if only the icon is visible.

https://github.com/mui-org/material-ui-x/blob/45093913e390b9c71b89a3debf76a58a46e68a2f/packages/grid/_modules_/grid/components/toolbar/GridToolbarDensitySelector.tsx#L99

👍 for a new issue/a follow-up to make this consistent between the different toolbar buttons.

I would personally argue that for the only icon use case, https://next.material-ui.com/system/screen-readers/#visually-hidden-elements has the potential to be more elegant. Less code, fewer translations. But If we want to make it work in a responsive way (hide the label on small screens), it might not fly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants