Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Object.assign in common, since it's not supported in IE #139

Merged
merged 1 commit into from
May 1, 2018
Merged

Replace Object.assign in common, since it's not supported in IE #139

merged 1 commit into from
May 1, 2018

Conversation

celebro
Copy link

@celebro celebro commented Apr 8, 2018

Object.assign() is not available in IE11. In environments without polyfills this library crashes on IE. This PR replaces it with a for-in loop.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 96.073% when pulling 67e19d8 on celebro:fix/remove-object-assign-for-IE into 6e60eb5 on mweststrate:master.

@scriby
Copy link
Contributor

scriby commented Apr 30, 2018

Can you post benchmarks before and after this change?

@mweststrate mweststrate merged commit 427308e into immerjs:master May 1, 2018
@mweststrate
Copy link
Collaborator

Merged, thanks @celebro!

@scriby tested, doesn't seem have real impact, but might a small change that it doesn't try to polyfill it by default

@celebro celebro deleted the fix/remove-object-assign-for-IE branch May 6, 2018 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants