Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.2.1: Env var name collision with dbt-core #39

Closed
will-misslin-ironclad opened this issue Oct 5, 2022 · 4 comments
Closed

Comments

@will-misslin-ironclad
Copy link

With the latest release, actions have begun to fail due to misconfiguration of logging.

dbt project folder set as: "/github/workspace/data_marts"
trying to parse bigquery token
success parsing plain token
saving console output in "/github/workspace/data_marts/dbt.log"
Error: 10:23:[20](https://github.com/**********/actions/runs/**********/jobs/**********#step:6:21).255872 [error] [MainThread]: Encountered an error:
[Errno 20] Not a directory: '/github/workspace/data_marts/dbt.log/dbt.log'
10:23:20  Encountered an error:
[Errno 20] Not a directory: '/github/workspace/data_marts/dbt.log/dbt.log'
Error: 10:[23](https://github.com/**********/actions/runs/**********/jobs/**********#step:6:24):20.[25](https://github.com/**********/actions/runs/**********/jobs/**********#step:6:26)7841 [error] [MainThread]: Traceback (most recent call last):

It seems that dbt-core expects that the new DBT_LOG_PATH env var (also available as the log-path yml config) points to a directory. However, the DBT_LOG_PATH in dbt-action seems to serve different purpose at points at the log file itself..

Perhaps the DBT_LOG_PATH env var in dbt-action is no longer necessary given the new dbt-core log-path config option? Happy to submit a PR if you are accepting them right now! 🙂

@joelazar
Copy link
Contributor

joelazar commented Oct 6, 2022

I've opened a pr for it --> #40

@mwhitaker
Copy link
Owner

Thank you both! When I created this action I wanted to capture the actual screen output, hence the DBT_LOG_PATH environment variable. Maybe it's no longer needed.

@joelazar I am still getting around to testing this myself, but did you test your PR that just renaming for now does the trick?

@joelazar
Copy link
Contributor

joelazar commented Oct 8, 2022

Thank you both! When I created this action I wanted to capture the actual screen output, hence the DBT_LOG_PATH environment variable. Maybe it's no longer needed.

@joelazar I am still getting around to testing this myself, but did you test your PR that just renaming for now does the trick?

@mwhitaker, yes, and it did the trick :)

@mwhitaker
Copy link
Owner

Thank you! Merged #40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants