Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jupytext 1.10.0 is way to big (44.7MB) #730

Closed
mwouts opened this issue Feb 4, 2021 · 6 comments · Fixed by #737
Closed

Jupytext 1.10.0 is way to big (44.7MB) #730

mwouts opened this issue Feb 4, 2021 · 6 comments · Fixed by #737
Labels
help wanted Extra attention is needed
Milestone

Comments

@mwouts
Copy link
Owner

mwouts commented Feb 4, 2021

There seem to be way to many files in the .tar.gz:

Screenshot from 2021-02-04 10-00-29

@mwouts mwouts added the help wanted Extra attention is needed label Feb 4, 2021
@mwouts mwouts added this to the 1.10.1 milestone Feb 4, 2021
@mwouts
Copy link
Owner Author

mwouts commented Feb 4, 2021

The tar.gz file is so big because of packages/labextension/node_modules (222MB when decompressed).
@martinRenou do you know how to filter out these files? I guess we don't really need them in the package, is that correct?

@martinRenou
Copy link
Contributor

Oh wow, that's huge indeed! https://www.reddit.com/r/ProgrammerHumor/comments/6s0wov/heaviest_objects_in_the_universe

Yes, this should definitely be removed from the source distribution. I guess a global-exclude */node_modules here would do the trick?

@mwouts
Copy link
Owner Author

mwouts commented Feb 5, 2021

LOL... love the link!

Well I tried a global-exclude yesterday but that did not seem to work. Actually the packaging process seems to generate another MANIFEST file (with no extension) and I was thinking that maybe that one is what controls what is included. Maybe I should ask for help on the jupyter_packaging tracker?

@martinRenou
Copy link
Contributor

martinRenou commented Feb 5, 2021

Actually the packaging process seems to generate another MANIFEST file (with no extension) and I was thinking that maybe that one is what controls what is included

Yes, I saw that. It seems to me that it's generated from your MANIFEST.in (by setuptools?)

@mwouts
Copy link
Owner Author

mwouts commented Feb 8, 2021

Hi @martinRenou , yes you were right, these files are controlled by my MANIFEST.in file. With the attached PR I do get a much more reasonable size (665K)!

@mwouts
Copy link
Owner Author

mwouts commented Feb 10, 2021

Just to confirm, it also worked well on the pypublish step 👍
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants