Upgrade sorl-thumbnail and Pillow #2678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we upgraded Pillow before we started seeing errors like the
following:
IOError: cannot write mode RGBA as JPEG
As a quick workaround we just downgraded Pillow, but that created a
different error:
IOError: encoder error -2 when writing image file
I've dug into this a bit more and it seems that the first error is fixed
in sorl-thumbnail 12.4.1. I think I tried upgrading to the latest sorl,
but that isn't compatible with Django 1.8, which is the version we're
currently on. So this change upgrades to the latest version of Pillow,
and to the latest compatible version of sorl.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we upgraded Pillow before we started seeing errors like the
following:
As a quick workaround we just downgraded Pillow, but that created a
different error:
I've dug into this a bit more and it seems that the first error is fixed
in sorl-thumbnail 12.4.1. I think I tried upgrading to the latest sorl,
but that isn't compatible with Django 1.8, which is the version we're
currently on. So this change upgrades to the latest version of Pillow,
and to the latest compatible version of sorl.
Fixes #2649
Fixes #2669