Regex validation in GitHub node prevents usage of enterprise GitHub

[emathias]

Hi,

I'd like to report a small issue regarding GitHub integration. I'm running n8n Version 1.79.3

At the moment, the regex validations in lines:

n8n/packages/nodes-base/nodes/Github/Github.node.ts

Line 556 in 37d4b00

regex: 'https:\\/\\/github.com\\/([-_0-9a-zA-Z]+)(?:.*)',

and

n8n/packages/nodes-base/nodes/Github/Github.node.ts

Line 615 in 37d4b00

regex: 'https:\\/\\/github.com\\/(?:[-_0-9a-zA-Z]+)\\/([-_.0-9a-zA-Z]+)(?:.*)',

Prevent the usage of the GH Enterprise server.

The fix:
IMHO, 'github.com' should not be hardcoded in regex. Instead, it can be extracted from credential. An extra field in the UI which configures the node would also do, but since GH credentials are instance bound, getting it from credential config would make more sense.

Thanks and kind regards

ps: getting owner and repo by name seems to work

[Joffcom]

Hey @emathias,

We have created an internal ticket to look into this which we will be tracking as "GHC-953"