Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure vote-by-hash emits hashes #1089

Closed
rkeene opened this issue Aug 22, 2018 · 1 comment · Fixed by #1090
Closed

Ensure vote-by-hash emits hashes #1089

rkeene opened this issue Aug 22, 2018 · 1 comment · Fixed by #1090
Assignees
@rkeene @PlasmaPower
Milestone
V15.2

Comments

@rkeene
Copy link
Contributor

rkeene commented Aug 22, 2018 •
edited
Loading

Ensure vote by hash emits hashes

tcpdump -X -nn port 54000 and udp and 'ip[0x21] = 0x05' and 'ip[0x22:2] != 0x0006'
@rkeene rkeene changed the title Ensure vote stapling staples votes Ensure vote-by-hash emits hashes Aug 22, 2018
@rkeene rkeene added this to the V15.1 milestone Aug 22, 2018
@rkeene
Copy link
Contributor Author

rkeene commented Aug 22, 2018

It seems like, from talking to Lee, reverting pull request #1062 is needed

@rkeene rkeene mentioned this issue Aug 22, 2018
Merged
@rkeene rkeene modified the milestones: V15.1, V15.2 Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rkeene rkeene

@PlasmaPower PlasmaPower

Labels
None yet
Projects
None yet
Milestone
V15.2
Development

Successfully merging a pull request may close this issue.

Ensure full blocks are not generated as part of vote-by-hash
2 participants
@rkeene @PlasmaPower