Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only bootstrap cemented blocks? #2945

Open
qwahzi opened this issue Sep 16, 2020 · 3 comments
Open

Only bootstrap cemented blocks? #2945

qwahzi opened this issue Sep 16, 2020 · 3 comments

Comments

@qwahzi
Copy link
Collaborator

qwahzi commented Sep 16, 2020

Per #beta-net discussion on Discord, it seems like some nodes might be trying to bootstrap forked blocks. Is it possible to only bootstrap cemented blocks? Seems like an easy win for both less bandwidth usage and improved fork resolution (fewer repeat forks), but I'm not sure sure if this has any hidden implications or difficult implementation issues.

@wezrule
Copy link
Contributor

wezrule commented Nov 17, 2020

Thanks! It's implemented here: #3047 Will be cherry-picked in DB10 to see if there's any issues that arise

@qwahzi
Copy link
Collaborator Author

qwahzi commented Dec 30, 2021

@zhyatt - Is this solved by the linked PRs? #3152 (replacing #3047). Not sure if "optionally send confirmed frontiers" is the same as "only send confirmed frontiers for bootstrap"

@zhyatt zhyatt added this to the Research for Future Release milestone Jan 3, 2022
@zhyatt
Copy link
Collaborator

zhyatt commented Jan 3, 2022

@zhyatt - Is this solved by the linked PRs? #3152 (replacing #3047). Not sure if "optionally send confirmed frontiers" is the same as "only send confirmed frontiers for bootstrap"

@qwahzi PR #3152 only implements the option to ask for confirmed blocks only on bootstrap, but does not set that as the default. It is mostly a debug option at this point. Although I don't recall the specific issues with bootstrapping on confirmed blocks, there are some considerations which may not allow this to be fully implemented. It needs further research so I have added it to the milestone for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants