Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test network.peer_max_tcp_attempts failing for Windows + LMDB environment #3621

Open
thsfs opened this issue Dec 20, 2021 · 1 comment
Labels
bug unit test Related to a new, changed or fixed unit test
Milestone

Comments

@thsfs
Copy link
Contributor

thsfs commented Dec 20, 2021

Disabled in #3622

CI run in which it failed: here

2021-12-18T12:05:29.2196655Z [ RUN      ] network.peer_max_tcp_attempts
2021-12-18T12:05:30.7059330Z Could not open lmdb environment: -1073741523, 
2021-12-18T12:05:30.7101613Z Assertion (status4 == 0) failed
2021-12-18T12:05:30.7104563Z void __cdecl nano::mdb_env::init(bool &,const class boost::filesystem::path &,class nano::mdb_env::options)
2021-12-18T12:05:30.7105865Z D:\a\nano-node\nano-node\nano\node\lmdb\lmdb_env.cpp:65
2021-12-18T12:05:30.7110348Z 
2021-12-18T12:05:31.5271141Z  0# boost::stacktrace::basic_stacktrace<std::allocator<boost::stacktrace::frame> >::init at C:\local\boost_1_70_0\boost\stacktrace\stacktrace.hpp:75
2021-12-18T12:05:31.5273360Z  1# boost::stacktrace::basic_stacktrace<std::allocator<boost::stacktrace::frame> >::basic_stacktrace<std::allocator<boost::stacktrace::frame> > at C:\local\boost_1_70_0\boost\stacktrace\stacktrace.hpp:127
2021-12-18T12:05:31.5292417Z  2# nano::generate_stacktrace at D:\a\nano-node\nano-node\nano\lib\utility.cpp:129
2021-12-18T12:05:31.5311041Z  3# assert_internal at D:\a\nano-node\nano-node\nano\lib\utility.cpp:174
2021-12-18T12:05:31.5333668Z  4# nano::mdb_env::init at D:\a\nano-node\nano-node\nano\node\lmdb\lmdb_env.cpp:66
2021-12-18T12:05:31.5334604Z  5# nano::mdb_env::mdb_env at D:\a\nano-node\nano-node\nano\node\lmdb\lmdb_env.cpp:8
2021-12-18T12:05:31.5335442Z  6# nano::mdb_store::mdb_store at D:\a\nano-node\nano-node\nano\node\lmdb\lmdb.cpp:72
2021-12-18T12:05:31.5337450Z  7# std::make_unique<nano::mdb_store,nano::logger_mt &,boost::filesystem::path,nano::ledger_constants &,nano::txn_tracking_config const &,std::chrono::duration<__int64,std::ratio<1,1000> > &,nano::lmdb_config const &,bool &,0> at C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\include\memory:3416
2021-12-18T12:05:31.5338914Z  8# nano::make_store at D:\a\nano-node\nano-node\nano\node\node.cpp:1840
2021-12-18T12:05:31.5339542Z  9# nano::node::node at D:\a\nano-node\nano-node\nano\node\node.cpp:94
2021-12-18T12:05:31.5340183Z 10# nano::node::node at D:\a\nano-node\nano-node\nano\node\node.cpp:78
2021-12-18T12:05:31.5341525Z 11# std::_Construct_in_place<nano::node,boost::asio::io_context &,unsigned short,boost::filesystem::path,nano::logging &,nano::work_pool &,nano::node_flags &> at C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\include\xutility:160
2021-12-18T12:05:31.5344994Z 12# std::_Ref_count_obj2<nano::node>::_Ref_count_obj2<nano::node><boost::asio::io_context &,unsigned short,boost::filesystem::path,nano::logging &,nano::work_pool &,nano::node_flags &> at C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\include\memory:2029
2021-12-18T12:05:31.5347249Z 13# std::make_shared<nano::node,boost::asio::io_context &,unsigned short,boost::filesystem::path,nano::logging &,nano::work_pool &,nano::node_flags &> at C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\include\memory:2748
2021-12-18T12:05:31.5348909Z 14# network_peer_max_tcp_attempts_Test::TestBody at D:\a\nano-node\nano-node\nano\core_test\network.cpp:922
2021-12-18T12:05:31.5350532Z 15# testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test,void> at D:\a\nano-node\nano-node\gtest\googletest\src\gtest.cc:2592
2021-12-18T12:05:31.5352212Z 16# testing::internal::HandleExceptionsInMethodIfSupported<testing::Test,void> at D:\a\nano-node\nano-node\gtest\googletest\src\gtest.cc:2643
2021-12-18T12:05:31.5353717Z 17# testing::Test::Run at D:\a\nano-node\nano-node\gtest\googletest\src\gtest.cc:2689
2021-12-18T12:05:31.5354551Z 18# testing::TestInfo::Run at D:\a\nano-node\nano-node\gtest\googletest\src\gtest.cc:2864
2021-12-18T12:05:31.5355534Z 19# testing::TestSuite::Run at D:\a\nano-node\nano-node\gtest\googletest\src\gtest.cc:3016
2021-12-18T12:05:31.5356660Z 20# testing::internal::UnitTestImpl::RunAllTests at D:\a\nano-node\nano-node\gtest\googletest\src\gtest.cc:5856
2021-12-18T12:05:31.5358633Z 21# testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool> at D:\a\nano-node\nano-node\gtest\googletest\src\gtest.cc:2592
2021-12-18T12:05:31.5361781Z 22# testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool> at D:\a\nano-node\nano-node\gtest\googletest\src\gtest.cc:2643
2021-12-18T12:05:31.5363277Z 23# testing::UnitTest::Run at D:\a\nano-node\nano-node\gtest\googletest\src\gtest.cc:5438
2021-12-18T12:05:31.5365792Z 24# RUN_ALL_TESTS at D:\a\nano-node\nano-node\gtest\googletest\include\gtest\gtest.h:2491
2021-12-18T12:05:31.5366697Z 25# main at D:\a\nano-node\nano-node\nano\core_test\core_test_main.cc:24
2021-12-18T12:05:31.5367573Z 26# invoke_main at d:\a01\_work\6\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:79
2021-12-18T12:05:31.5368521Z 27# __scrt_common_main_seh at d:\a01\_work\6\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288
2021-12-18T12:05:31.5370047Z 28# __scrt_common_main at d:\a01\_work\6\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:331
2021-12-18T12:05:31.5371047Z 29# mainCRTStartup at d:\a01\_work\6\s\src\vctools\crt\vcstartup\src\startup\exe_main.cpp:17
2021-12-18T12:05:31.5371734Z 30# BaseThreadInitThunk in KERNEL32
2021-12-18T12:05:31.5372448Z 31# RtlUserThreadStart in ntdll
@dsiganos
Copy link
Contributor

I imagine the problem here is that it is creating too many node objects and it is running out of resources.
We should be able to rewrite this test to not need to use full node objects.

@qwahzi qwahzi added bug unit test Related to a new, changed or fixed unit test labels Jan 7, 2023
@qwahzi qwahzi added this to the Backlog milestone Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug unit test Related to a new, changed or fixed unit test
Projects
None yet
Development

No branches or pull requests

3 participants