Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the confirmation_height_clear option to require the account argument #3831

Closed
thsfs opened this issue May 26, 2022 · 2 comments · Fixed by #3836
Closed

Change the confirmation_height_clear option to require the account argument #3831

thsfs opened this issue May 26, 2022 · 2 comments · Fixed by #3836
Assignees
@dsiganos
Labels
cli Changes related to the Command Line Interface documentation This item indicates the need for or supplies updated or expanded documentation good first issue Good for newcomers help wanted
Milestone
V24.0

Comments

@thsfs
Copy link
Contributor

thsfs commented May 26, 2022

For safety, the confirmation_height_clear should be changed to require an account argument. This argument should have either an account number or "all", to specify the confirmation height of all accounts will be cleaned;
@thsfs thsfs added documentation This item indicates the need for or supplies updated or expanded documentation cli Changes related to the Command Line Interface labels May 26, 2022
This was referenced Jun 9, 2022
Merged
Closed
@qwahzi
Copy link
Collaborator

qwahzi commented Jan 4, 2023

This one looks like it was also completed already. Tagging @dsiganos for review

@qwahzi qwahzi added this to the V24.0 milestone Jan 4, 2023
@dsiganos dsiganos self-assigned this Jan 4, 2023
@dsiganos
Copy link
Contributor

dsiganos commented Jan 5, 2023

Resolved by #3836

@dsiganos dsiganos closed this as completed Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsiganos dsiganos

Labels
cli Changes related to the Command Line Interface documentation This item indicates the need for or supplies updated or expanded documentation good first issue Good for newcomers help wanted
Projects
None yet
Milestone
V24.0
Development

Successfully merging a pull request may close this issue.

confirmation_height_clear cli account param JerzyStanislawski/nano-node
3 participants
@dsiganos @qwahzi @thsfs