Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating to use c++20 #4017

Merged
merged 6 commits into from
Jan 16, 2023
Merged

Updating to use c++20 #4017

merged 6 commits into from
Jan 16, 2023

Conversation

clemahieu
Copy link
Contributor

Fixing various type ambiguities flagged in c++20 mode.

dsiganos
dsiganos previously approved these changes Dec 3, 2022
@clemahieu
Copy link
Contributor Author

Looks like boost will need a new version.

Boost asio coroutine support: https://www.boost.org/users/history/version_1_74_0.html
c++20 compiler testing: https://www.boost.org/users/history/version_1_77_0.html

@clemahieu clemahieu marked this pull request as draft December 8, 2022 16:22
@guilhermelawless
Copy link
Contributor

guilhermelawless commented Dec 30, 2022

Stumbled upon here and remembered this one :)

// std::erase_if in c++20

@clemahieu clemahieu marked this pull request as ready for review January 14, 2023 16:29
@clemahieu clemahieu merged commit 9be0f0a into nanocurrency:develop Jan 16, 2023
@thsfs thsfs added enhancement documentation This item indicates the need for or supplies updated or expanded documentation non-functional change labels Mar 1, 2023
@thsfs
Copy link
Contributor

thsfs commented Mar 1, 2023

This change requires updating the documentation website, switching the compiler version from C++17 to C++20.

clemahieu added a commit that referenced this pull request Mar 7, 2023
Fixes the TSAN build by updating flat buffers to the recent version.
Updating flatbuffer library to v23.3.3.
C++20 compatibility with compiler version necessitated updating docker container to be Ubuntu 22.04

This commit is associated with the c++20 update #4017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This item indicates the need for or supplies updated or expanded documentation enhancement non-functional change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants