From 889c4cd1975404fc3ceb724aa312985ba409249d Mon Sep 17 00:00:00 2001 From: Dimitrios Siganos Date: Wed, 8 Feb 2023 17:10:11 +0000 Subject: [PATCH] Bugfix: max counting had reversed polarity, it counted successes not fails The counters: nano::stat::type::udp, nano::stat::detail::udp_max_per_subnetwork nano::stat::type::udp, nano::stat::detail::udp_max_per_ip --- nano/node/transport/udp.cpp | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/nano/node/transport/udp.cpp b/nano/node/transport/udp.cpp index 2c1579e867..89ecccef67 100644 --- a/nano/node/transport/udp.cpp +++ b/nano/node/transport/udp.cpp @@ -635,12 +635,12 @@ bool nano::transport::udp_channels::max_ip_connections (nano::endpoint const & e } auto const address (nano::transport::ipv4_address_or_ipv6_subnet (endpoint_a.address ())); nano::unique_lock lock{ mutex }; - auto const result = channels.get ().count (address) >= node.network_params.network.max_peers_per_ip; - if (!result) + auto const error = channels.get ().count (address) >= node.network_params.network.max_peers_per_ip; + if (error) { node.stats.inc (nano::stat::type::udp, nano::stat::detail::udp_max_per_ip, nano::stat::dir::out); } - return result; + return error; } bool nano::transport::udp_channels::max_subnetwork_connections (nano::endpoint const & endpoint_a) @@ -651,12 +651,12 @@ bool nano::transport::udp_channels::max_subnetwork_connections (nano::endpoint c } auto const subnet (nano::transport::map_address_to_subnetwork (endpoint_a.address ())); nano::unique_lock lock{ mutex }; - auto const result = channels.get ().count (subnet) >= node.network_params.network.max_peers_per_subnetwork; - if (!result) + auto const error = channels.get ().count (subnet) >= node.network_params.network.max_peers_per_subnetwork; + if (error) { node.stats.inc (nano::stat::type::udp, nano::stat::detail::udp_max_per_subnetwork, nano::stat::dir::out); } - return result; + return error; } bool nano::transport::udp_channels::max_ip_or_subnetwork_connections (nano::endpoint const & endpoint_a)