Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Qt version to 5.15.2 for Windows builds #4242

Merged
merged 1 commit into from
Jun 1, 2023

Conversation

thsfs
Copy link
Contributor

@thsfs thsfs commented May 31, 2023

Bumps the Qt version to 5.15.2 for Windows builds. This change makes the builds compatible with the recent compiler related upgrades for C++20.

@thsfs thsfs requested a review from clemahieu May 31, 2023 21:21
@thsfs thsfs added routine This item indicates the need for or supplies a routine change ci/cd labels May 31, 2023
@thsfs
Copy link
Contributor Author

thsfs commented May 31, 2023

There are still some warnings/errors to be sorted out:

2023-05-31T22:08:46.0320580Z qtmain.lib(qtmain_win.obj) : warning LNK4099: PDB '' was not found with 'qtmain.lib(qtmain_win.obj)' or at ''; linking object as if no debug info [D:\a\nano-node\nano-node\build\nano_wallet.vcxproj]
2023-05-31T22:08:46.0322226Z      Creating library D:/a/nano-node/nano-node/build/RelWithDebInfo/nano_wallet.lib and object D:/a/nano-node/nano-node/build/RelWithDebInfo/nano_wallet.exp
2023-05-31T22:08:57.5193797Z   nano_wallet.vcxproj -> D:\a\nano-node\nano-node\build\RelWithDebInfo\nano_wallet.exe
2023-05-31T22:08:57.6182497Z   Building Custom Rule D:/a/nano-node/nano-node/CMakeLists.txt
2023-05-31T22:08:57.8724624Z   -- Install configuration: "RelWithDebInfo"
2023-05-31T22:08:57.8725646Z   -- Installing: C:/Program Files/nano-node/./config-node.toml.sample
2023-05-31T22:08:57.8770223Z   -- Installing: C:/Program Files/nano-node/./config-rpc.toml.sample
2023-05-31T22:08:57.8786402Z   -- Installing: C:/Program Files/nano-node/./nano_wallet.exe
2023-05-31T22:08:57.9371211Z   -- Installing: C:/Program Files/nano-node/./nano_wallet.com
2023-05-31T22:08:58.0057344Z   -- Installing: C:/Program Files/nano-node/./vc_redist.x64.exe
2023-05-31T22:09:01.2483934Z   -- Installing: C:/Program Files/nano-node/./libGLESv2.dll
2023-05-31T22:09:01.5015803Z   -- Installing: C:/Program Files/nano-node/./Qt5Core.dll
2023-05-31T22:09:01.9540960Z   -- Installing: C:/Program Files/nano-node/./Qt5Gui.dll
2023-05-31T22:09:02.4595611Z   -- Installing: C:/Program Files/nano-node/./Qt5Widgets.dll
2023-05-31T22:09:02.8479047Z   -- Installing: C:/Program Files/nano-node/./Qt5WinExtras.dll
2023-05-31T22:09:02.8663403Z   -- Installing: C:/Program Files/nano-node/platforms/qwindows.dll
2023-05-31T22:09:02.9829183Z   -- Installing: C:/Program Files/nano-node/./api/flatbuffers
2023-05-31T22:09:02.9835863Z   -- Installing: C:/Program Files/nano-node/./api/flatbuffers/nanoapi.fbs
2023-05-31T22:09:02.9947460Z   -- Installing: C:/Program Files/nano-node/./nano_node.exe
2023-05-31T22:09:03.0883938Z   -- Installing: C:/Program Files/nano-node/./nano_rpc.exe
2023-05-31T22:09:03.3918053Z "Packaging NSIS"
2023-05-31T22:09:03.3939127Z '"\cpack.exe"' is not recognized as an internal or external command,
2023-05-31T22:09:03.3939917Z operable program or batch file.
2023-05-31T22:09:03.3940271Z "Packaging ZIP"
2023-05-31T22:09:03.3950447Z '"\cpack.exe"' is not recognized as an internal or external command,
2023-05-31T22:09:03.3950883Z operable program or batch file.
2023-05-31T22:09:04.8866646Z SignTool Error: Missing filename.
2023-05-31T22:09:04.9223608Z 
2023-05-31T22:09:05.2014733Z ##[error]Process completed with exit code 1.
2023-05-31T22:09:05.3199856Z Post job cleanup.

@clemahieu clemahieu force-pushed the bump-qt-for-windows-dep branch from efcb528 to 6293edc Compare June 1, 2023 13:54
@clemahieu clemahieu merged commit ad841df into nanocurrency:develop Jun 1, 2023
clemahieu pushed a commit that referenced this pull request Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd routine This item indicates the need for or supplies a routine change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants