From de0d259b2b5d2919250272c25a279818afbb3b29 Mon Sep 17 00:00:00 2001 From: Colin LeMahieu Date: Mon, 19 Feb 2024 22:32:30 +0000 Subject: [PATCH] Remove node::rep_block function that was only used in tests. --- nano/core_test/node.cpp | 12 ------------ nano/core_test/wallet.cpp | 13 ------------- nano/node/node.cpp | 12 ------------ nano/node/node.hpp | 1 - 4 files changed, 38 deletions(-) diff --git a/nano/core_test/node.cpp b/nano/core_test/node.cpp index 4faa66e0bb..6edce227bd 100644 --- a/nano/core_test/node.cpp +++ b/nano/core_test/node.cpp @@ -115,18 +115,6 @@ TEST (node, balance) ASSERT_EQ (std::numeric_limits::max (), system.nodes[0]->ledger.account_balance (transaction, nano::dev::genesis_key.pub)); } -TEST (node, representative) -{ - nano::test::system system (1); - auto block1 (system.nodes[0]->rep_block (nano::dev::genesis_key.pub)); - { - auto transaction (system.nodes[0]->store.tx_begin_read ()); - ASSERT_TRUE (system.nodes[0]->ledger.store.block.exists (transaction, block1)); - } - nano::keypair key; - ASSERT_TRUE (system.nodes[0]->rep_block (key.pub).is_zero ()); -} - TEST (node, send_unkeyed) { nano::test::system system (1); diff --git a/nano/core_test/wallet.cpp b/nano/core_test/wallet.cpp index e7c8356eb5..c53b6c13c4 100644 --- a/nano/core_test/wallet.cpp +++ b/nano/core_test/wallet.cpp @@ -223,19 +223,6 @@ TEST (wallet, spend) ASSERT_EQ (0, node1.balance (nano::dev::genesis_key.pub)); } -TEST (wallet, change) -{ - nano::test::system system (1); - system.wallet (0)->insert_adhoc (nano::dev::genesis_key.prv); - nano::keypair key2; - auto block1 (system.nodes[0]->rep_block (nano::dev::genesis_key.pub)); - ASSERT_FALSE (block1.is_zero ()); - ASSERT_NE (nullptr, system.wallet (0)->change_action (nano::dev::genesis_key.pub, key2.pub)); - auto block2 (system.nodes[0]->rep_block (nano::dev::genesis_key.pub)); - ASSERT_FALSE (block2.is_zero ()); - ASSERT_NE (block1, block2); -} - TEST (wallet, partial_spend) { nano::test::system system (1); diff --git a/nano/node/node.cpp b/nano/node/node.cpp index fe55224fa8..b2a590699d 100644 --- a/nano/node/node.cpp +++ b/nano/node/node.cpp @@ -744,18 +744,6 @@ nano::uint128_t nano::node::weight (nano::account const & account_a) return ledger.weight (account_a); } -nano::block_hash nano::node::rep_block (nano::account const & account_a) -{ - auto const transaction (store.tx_begin_read ()); - nano::block_hash result (0); - auto info = ledger.account_info (transaction, account_a); - if (info) - { - result = ledger.representative (transaction, info->head); - } - return result; -} - nano::uint128_t nano::node::minimum_principal_weight () { return online_reps.trended () / network_params.network.principal_weight_factor; diff --git a/nano/node/node.hpp b/nano/node/node.hpp index 247dd35ccf..b26c452c2a 100644 --- a/nano/node/node.hpp +++ b/nano/node/node.hpp @@ -92,7 +92,6 @@ class node final : public std::enable_shared_from_this std::shared_ptr block (nano::block_hash const &); std::pair balance_pending (nano::account const &, bool only_confirmed); nano::uint128_t weight (nano::account const &); - nano::block_hash rep_block (nano::account const &); nano::uint128_t minimum_principal_weight (); void ongoing_rep_calculation (); void ongoing_bootstrap ();