Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Labels are removed on unzoom in V2.0.0-next 4 #1449

Closed
RonnyWeiss opened this issue Jun 17, 2020 · 3 comments
Closed

Labels are removed on unzoom in V2.0.0-next 4 #1449

RonnyWeiss opened this issue Jun 17, 2020 · 3 comments
Labels
bug
Milestone
2.0-next

Comments

@RonnyWeiss
Copy link

When zoom into chart e.g. by scroll and then call unzoom labels are removed
Could you please fix that.

Chart Json:
chart.txt

2020-06-17_08h36_28

And in all Version when zoom the labels are running out of the chart as you can see in gif animation this is in all version is this a bug or a feature? because when legend is right it looks not so nice.

Thank you for fixing so fast the other issues.

Kind regards

Ronny
@RonnyWeiss
Copy link
Author

I hope I am not annoying with the fact that I am already validating and testing the new V2.0 and reporting every error? :-)

@netil
Copy link
Member

netil commented Jun 17, 2020

@RonnyWeiss, your reporting will help to find potential issue during the RC release period.
Plz, don't hesitate posting any issue that comes in mind if you think is not working correctly. :)

Anyway, I'll be try figuring out this, Thanks a lot!

@netil netil added the bug label Jun 17, 2020
netil added a commit that referenced this issue Jun 17, 2020
@netil
fix(axis): fix incorrect clip node handling
a8c6f96 
Correct incorrect reference of clip node and state value.

Ref #1449
netil added a commit that referenced this issue Jun 17, 2020
@netil
fix(axis): make axis clip-path to fit real axis size
7419f44 
WIP

Ref #1449
netil added a commit that referenced this issue Jun 19, 2020
@netil
refactor(clip): update on clipPath dimension
11e4202 
- set the dimension of x/y clipPath to be more narrowed
- removed .bb-zoom-rect

Ref #1449
netil pushed a commit that referenced this issue Jun 19, 2020
@semantic-release-bot
chore(release): 2.0.0-next.5 [skip ci]
169f7c3 
# [2.0.0-next.5](2.0.0-next.4...2.0.0-next.5) (2020-06-19)

### Bug Fixes

* **axis:** fix incorrect clip node handling ([a8c6f96](a8c6f96)), closes [#1449](#1449)
* **axis:** make axis clip-path to fit real axis size ([7419f44](7419f44)), closes [#1449](#1449)
@netil
Copy link
Member

netil commented Jun 19, 2020

The labels are running out

The reason were x Axis tick texts are showing out of the x Axis size is because it should have some space to not cut tick text where is positioned at the end of each corner(left and right).

image

But, from this it will look weird in case you do zoom interaction moving chart back and forth where tick texts are running out the x Axis width size.

I did some updates mitigating giving too much space for each corner, and will work as the below screenshot.

x-axis-clip-path

The label disappearing bug and the mitigation of text running out are updated in 2.0.0-next.5 release.

@netil netil closed this as completed Jun 19, 2020
@netil netil added this to the 2.0-next milestone Jun 19, 2020
netil pushed a commit that referenced this issue Jul 16, 2020
@semantic-release-bot
chore(release): 2.0.0 [skip ci]
dc0ba30 
# [2.0.0](1.12.11...2.0.0) (2020-07-16)

### Bug Fixes

* **all:** Fix test cases ([2e1ad79](2e1ad79))
* **arc:** fix applying data.labels.colors ([#1448](#1448)) ([c128fad](c128fad)), closes [#1440](#1440)
* **axis:** fix incorrect clip node handling ([a8c6f96](a8c6f96)), closes [#1449](#1449)
* **axis:** make axis clip-path to fit real axis size ([7419f44](7419f44)), closes [#1449](#1449)
* **bar:** fix bar width scale on zoom ([59073bd](59073bd)), closes [#1476](#1476)
* **data:** fix for data.labels=false ([b7a0972](b7a0972)), closes [#1444](#1444)
* **data.selection:** fix selection.isselectable value check ([9d41a04](9d41a04))
* **gauge:** fixed wrong bottom padding calculation ([0542586](0542586)), closes [#1441](#1441) [#1471](#1471)
* **legend:** Don't bind event when interaction is false ([4546c00](4546c00))
* **point:** Correct focus.only to work in mobile env ([67eea16](67eea16))
* **point:** Correct point.focus.only ([1686594](1686594))
* **point:** update point generation ([da63e39](da63e39))
* **subchar:** correct subchart rendering ([44ed216](44ed216)), closes [#1458](#1458)

### Code Refactoring

* **all:** v2 updates ([e23998f](e23998f)), closes [#758](#758) [#757](#757) [#756](#756) [#36](#36)
* **module:** implement ESM index ([85caf71](85caf71))

### Features

* **axis:** Intent to ship log scale  ([6fdf3e4](6fdf3e4)), closes [#1351](#1351)
* **bar:** Intent to ship bar.label.threshold ([72a7b7f](72a7b7f)), closes [#1427](#1427)
* **gauge:** Intent to ship gauge.label.threshold ([#1443](#1443)) ([9a0807e](9a0807e)), closes [#1439](#1439)
* **interaction:** split selection, subchart & zoom ([ba1e4f2](ba1e4f2))
* **point:** Intent to ship point.focus.only ([bb70347](bb70347))

### BREAKING CHANGES

* **all:** v2 updates
* **module:** new index for ESM build

- split Axis releated size from size.ts --> size.axis.ts
- split common main option from Options.ts --> ./common/main.ts
- Instead export Axis class, add .getAxisInstance() to make beneficial
  from tree-shaking
@netil netil mentioned this issue Jul 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.0-next
Development

No branches or pull requests
2 participants
@netil @RonnyWeiss