Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Look for possibility to decrease node generation #36

Closed
netil opened this issue Jun 23, 2017 · 1 comment
Closed

Look for possibility to decrease node generation #36

netil opened this issue Jun 23, 2017 · 1 comment
Assignees
@netil
Labels
enhancement
Milestone
2.0-next

Comments

@netil
Copy link
Member

netil commented Jun 23, 2017

Description

There're options to handle the visibility of specific element using xxx.show options.

Even they aren't rendered, still nodes are created, which are unnecessary in most cases.
Look possibility to not generate those nodes if aren't shown, which can be more efficient.
@netil netil self-assigned this Jun 23, 2017
@netil netil modified the milestone: 1.1.0 Jul 10, 2017
@netil netil mentioned this issue Jul 13, 2017
Merged
@netil
Copy link
Member Author

netil commented Aug 4, 2017

There're other options to check, so this issue should be remain open until all related options are considered sufficiently.

@netil netil reopened this Aug 14, 2017
@netil netil modified the milestone: 1.1.0 Sep 13, 2017
@netil netil mentioned this issue Dec 31, 2018
Merged
netil added a commit that referenced this issue Dec 31, 2018
@netil
refactor(axis): Do not generate unnecessary axes (#717)
0cfb6cd 
Make not generate axes when they're not visible.
This will also improve shrinking unnecessary node handligs.

Ref #36
Close #717
@netil netil mentioned this issue Jan 28, 2019
Merged
netil added a commit that referenced this issue Jan 28, 2019
@netil
refactor(all): Decreasing node generation
6ca51b2 
not generate nodes for when:
 - subchart's clip-path if isn't used
 - data.empty.label.text isn't specified
 - grid lines aren't specified

Ref #36
Close #750
@netil netil mentioned this issue Jan 30, 2019
Merged
netil added a commit that referenced this issue Jan 30, 2019
@netil
refactor(internal): Reduce complexity
86f44d2 
- Split of redraw() to reduce code complexity
- Reduced the list of redraw. Make to redraw only existing chart types

Ref #36
Close #751
@netil netil mentioned this issue Jan 31, 2019
Closed
@netil netil added this to the 2.0-next milestone Mar 13, 2020
netil added a commit that referenced this issue Jun 8, 2020
@netil
refactor(all): v2 updates
e23998f 
BREAKING CHANGE: v2 updates

Ref #758, #757, #756, #36
netil pushed a commit that referenced this issue Jun 8, 2020
@semantic-release-bot
chore(release): 2.0.0-next.1 [skip ci]
0bb7b60 
# [2.0.0-next.1](1.12.0-next.5...2.0.0-next.1) (2020-06-08)

### Bug Fixes

* **all:** Fix test cases ([2e1ad79](2e1ad79))
* **point:** Correct focus.only to work in mobile env ([67eea16](67eea16))
* **point:** Correct point.focus.only ([1686594](1686594))

### Code Refactoring

* **all:** v2 updates ([e23998f](e23998f)), closes [#758](#758) [#757](#757) [#756](#756) [#36](#36)
* **module:** implement ESM index ([85caf71](85caf71))

### Features

* **point:** Intent to ship point.focus.only ([bb70347](bb70347))

### BREAKING CHANGES

* **all:** v2 updates
* **module:** new index for ESM build

- split Axis releated size from size.ts --> size.axis.ts
- split common main option from Options.ts --> ./common/main.ts
- Instead export Axis class, add .getAxisInstance() to make beneficial
  from tree-shaking
@netil netil mentioned this issue Jul 2, 2020
Closed
@netil netil closed this as completed Jul 2, 2020
netil pushed a commit that referenced this issue Jul 16, 2020
@semantic-release-bot
chore(release): 2.0.0 [skip ci]
dc0ba30 
# [2.0.0](1.12.11...2.0.0) (2020-07-16)

### Bug Fixes

* **all:** Fix test cases ([2e1ad79](2e1ad79))
* **arc:** fix applying data.labels.colors ([#1448](#1448)) ([c128fad](c128fad)), closes [#1440](#1440)
* **axis:** fix incorrect clip node handling ([a8c6f96](a8c6f96)), closes [#1449](#1449)
* **axis:** make axis clip-path to fit real axis size ([7419f44](7419f44)), closes [#1449](#1449)
* **bar:** fix bar width scale on zoom ([59073bd](59073bd)), closes [#1476](#1476)
* **data:** fix for data.labels=false ([b7a0972](b7a0972)), closes [#1444](#1444)
* **data.selection:** fix selection.isselectable value check ([9d41a04](9d41a04))
* **gauge:** fixed wrong bottom padding calculation ([0542586](0542586)), closes [#1441](#1441) [#1471](#1471)
* **legend:** Don't bind event when interaction is false ([4546c00](4546c00))
* **point:** Correct focus.only to work in mobile env ([67eea16](67eea16))
* **point:** Correct point.focus.only ([1686594](1686594))
* **point:** update point generation ([da63e39](da63e39))
* **subchar:** correct subchart rendering ([44ed216](44ed216)), closes [#1458](#1458)

### Code Refactoring

* **all:** v2 updates ([e23998f](e23998f)), closes [#758](#758) [#757](#757) [#756](#756) [#36](#36)
* **module:** implement ESM index ([85caf71](85caf71))

### Features

* **axis:** Intent to ship log scale  ([6fdf3e4](6fdf3e4)), closes [#1351](#1351)
* **bar:** Intent to ship bar.label.threshold ([72a7b7f](72a7b7f)), closes [#1427](#1427)
* **gauge:** Intent to ship gauge.label.threshold ([#1443](#1443)) ([9a0807e](9a0807e)), closes [#1439](#1439)
* **interaction:** split selection, subchart & zoom ([ba1e4f2](ba1e4f2))
* **point:** Intent to ship point.focus.only ([bb70347](bb70347))

### BREAKING CHANGES

* **all:** v2 updates
* **module:** new index for ESM build

- split Axis releated size from size.ts --> size.axis.ts
- split common main option from Options.ts --> ./common/main.ts
- Instead export Axis class, add .getAxisInstance() to make beneficial
  from tree-shaking
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@netil netil

Labels
enhancement
Projects
None yet
Milestone
2.0-next
Development

No branches or pull requests
1 participant
@netil