-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs for fine-grained permissions from keycloak #480
Conversation
✅ Deploy Preview for nebari-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had some follow up questions but also, I'm still a little confused on the difference between Client and component. Can you add more detail explaining that somewhere?
- `admin!namespace=analyst`: grants `admin` access to namespace `analyst` | ||
- `developer!namespace=nebari-git`: grants `developer` access to namespace `nebari-git` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are admin
and developer
roles that exist within conda-store itself? Or are those admin
and developer
as we know it within Nebari's keycloak groups?
What does permissions do admin
and developer
have? In other words, read/write/delete access?
And depending on how you'd answer those questions, more details around what that means within the namespace would be helpful as well. i.e. Can this user now read/create/delete environments in the namespace?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are admin and developer roles that exist within conda-store itself? Or are those admin and developer as we know it within Nebari's keycloak groups?
Yes they do exists in conda-store: viewer, developer (or editor), admin
What does permissions do admin and developer have? In other words, read/write/delete access?
What does permissions do admin and developer have? In other words, read/write/delete access?
admin
has full access and developer
(also same as editor
) has edit access, here is the full list: https://github.com/conda-incubator/conda-store/blob/67a4860ac5d9cf33285b5641e5dbb3b9ce61b1c7/conda-store-server/conda_store_server/server/auth.py#L146
And depending on how you'd answer those questions, more details around what that means within the namespace would be helpful as well. i.e. Can this user now read/create/delete environments in the namespace?
I'll add a few line summary and point to conda-store if that make sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I think that sounds like a good solution
I agree about the images being hard to see. I find that if I make my browser window half the width of the monitor, then take the screenshot that it helps make the screenshot less wide (more squarish) and easier to see. |
Co-authored-by: Kim Pevey <[email protected]>
Co-authored-by: Kim Pevey <[email protected]>
Looks much better now! For the record - what did you do? |
Reference Issues or PRs
Relevant implementation
What does this implement/fix?
Put a
x
in the boxes that applyTesting
Documentation
Access-centered content checklist
Text styling
H1
or#
in markdown).Non-text content
Any other comments?