Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] - Allow configuring jupyter_server_config.py and overrides.json from config file #2247

Closed
krassowski opened this issue Feb 15, 2024 · 1 comment · Fixed by #2249
Closed
Assignees
Labels
project: JATIC Work item needed for the JATIC project type: enhancement 💅🏼 New feature or request

Comments

@krassowski
Copy link
Member

Feature description

Currently only a few options in jupyter_server_config.py can be configured from the config file. No overrides options can be configured from the config file. This severely restricts Jupyter configuration.

Value and/or benefit

  • More configuration options

Anything else?

No response

@krassowski
Copy link
Member Author

Thinking more on this, there is a different level of trust to the operator with respect to allowing full configuration of jupyter_server_config vs overrides. overrides mostly pertain the user UI and flipping them is unlikely to ever lead to a major breakage. On the other hand, flipping some settings in jupyter_server_config can lead to unintended or dangerous consequences and here having an allow-list of settings that operators can change might be desirable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project: JATIC Work item needed for the JATIC project type: enhancement 💅🏼 New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

1 participant