Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] - Force the trailing slash when using jupyter server proxy #2383

Closed
Adam-D-Lewis opened this issue Apr 5, 2024 · 1 comment · Fixed by #2387
Closed

[ENH] - Force the trailing slash when using jupyter server proxy #2383

Adam-D-Lewis opened this issue Apr 5, 2024 · 1 comment · Fixed by #2387
Assignees
Milestone

Comments

@Adam-D-Lewis
Copy link
Member

Adam-D-Lewis commented Apr 5, 2024

Feature description

More info: #2273, nebari-dev/nebari-docs#240 (comment)

I see that if a process (panel, r-shiny, etc.) returns a relative path e.g. jquery-3.6.0/jquery.min.js then you must use a trailing slash when accessing the process through jupyter-server-proxy. e.g. https://nebari.quansight.dev/user/[email protected]/proxy/5333/ instead of https://nebari.quansight.dev/user/[email protected]/proxy/5333. The trailing slash is important.

Otherwise, you get the issue described in #2273.

Anything else?

No response

@Adam-D-Lewis
Copy link
Member Author

Adam-D-Lewis commented Apr 5, 2024

I tested which visualization libraries require the closing slash at least for simple apps and found that even simple panel and r-shiny apps will break without the path, but really any could use a relative path and users would experience the same issue.

@Adam-D-Lewis Adam-D-Lewis changed the title [ENH] - Force the closing slash when using jupyter server proxy [ENH] - Force the trailing slash when using jupyter server proxy Apr 9, 2024
@viniciusdc viniciusdc added this to the Next release milestone Apr 9, 2024
@github-project-automation github-project-automation bot moved this from New 🚦 to Done 💪🏾 in 🪴 Nebari Project Management Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

2 participants