Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move external_container_reg to earlier stage #1053

Merged
merged 1 commit into from
Feb 11, 2022
Merged

Move external_container_reg to earlier stage #1053

merged 1 commit into from
Feb 11, 2022

Conversation

danlester
Copy link
Contributor

Fixes #1052

Changes:

Move external_container_reg Terraform sections from stage 08 to stage 03.

Types of changes

What types of changes does your code introduce?

Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

@danlester danlester added this to the Release v0.4.0 milestone Feb 11, 2022
Copy link
Member

@costrouc costrouc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danlester makes sense. Since I remember you will need a custom keycloak image etc. Thanks for catching this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

external_container_reg needs to be in stage 03 not 08 [bug]
2 participants