Update skip_remote_state_provision
default value
#1521
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes | Closes | Resolves #
Changes introduced in this PR:
skip_remote_state_provision
default value fromTrue
toFalse
By keeping the
skip_remote_state_provision
default value asTrue,
we were inadvertently revoking the creation of the terraform state bucket during the first deployments. Which is used during the stage provision phase:nebari/nebari/deploy.py
Lines 201 to 208 in 77d15e7
I think the reason we didn't spot this sooner as due to until #1519 we still used a mix of the new CLI with the old
qhub
entry points.Image of the error caused during deployment on GCP with
terraform_state: remote
(default) set in the configEven with no mention of
--skip-remote-state-provision
you can see the log message right at the beginning finalizing the skip.Types of changes
What types of changes does your PR introduce?
Put an
x
in the boxes that applyTesting
Requires testing
In case you checked yes, did you write tests?
Documentation
Does your contribution include breaking changes or deprecations?
If so have you updated the documentation?
Further comments (optional)
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered and more.