Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Update dashboard environment #1655

Merged
merged 3 commits into from
Feb 16, 2023

Conversation

ppwadhwa
Copy link
Contributor

Updates the dashboard environment to pinned versions of most packages. All examples can be launched via cds dashboards.

Reference Issues or PRs

Addresses https://github.com/kcpevey/nebari_work/issues/3

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@kcpevey
Copy link
Contributor

kcpevey commented Feb 16, 2023

Can you confirm all the new dashboard examples work with this environment?

@ppwadhwa
Copy link
Contributor Author

I did confirm they work with all the new examples. I can check again, but they deployed with cds dashboards.

@kcpevey
Copy link
Contributor

kcpevey commented Feb 16, 2023

Adding @viniciusdc and @iameskild (whichever gets to it first) for one final look before merging

Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ppwadhwa :)

@kcpevey kcpevey merged commit ed20f0a into nebari-dev:develop Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants