1811 adding missing general node selectors/affinity to core components #2214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is ready for review! |
|
I'll review this later this week |
| @@ -63,9 +63,34 @@ data "aws_eks_cluster_auth" "main" { | |||
|
|
|||
| resource "aws_eks_addon" "aws-ebs-csi-driver" { | |||
| # required for Kubernetes v1.23+ on AWS | |||
| addon_name = "aws-ebs-csi-driver" | |||
| cluster_name = aws_eks_cluster.main.name | |||
| resolve_conflicts = "OVERWRITE" | |||
There was a problem hiding this comment.
What is the reason for removing this?
Docs for reference:
|
@sblair-metrostar Thanks for this PR, and sorry for the delay. I think this is an good addition, and I'd like to get it into Nebari. Are you still interested in working on it? |
| @@ -3,7 +3,6 @@ resource "aws_vpc" "main" { | |||
|
|
|||
| enable_dns_support = true | |||
| enable_dns_hostnames = true | |||
| enable_classiclink = false | |||
There was a problem hiding this comment.
Nothing to change here, just a note.
Note: This was removed since it's no longer supported as of August 23, 2023 - https://aws.amazon.com/blogs/aws/ec2-classic-is-retiring-heres-how-to-prepare/
10 tasks
|
Since I haven't heard back from @sblair-metrostar, I'm going to close this PR in favor of #2353. Thanks for your contribution @sblair-metrostar! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #1811
Ref #2168
What does this implement/fix?
Put a
xin the boxes that applyTesting
Any other comments?