add trailing slash for jupyterhub proxy paths #2387
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues or PRs
Fixes #2383
This PR redirects any attempts to visit
https://<domain>/user/.*/proxy/(\d+)
to the same path, but with the trailing slash appended.e.g.
https://nebari.quansight.dev/user/[email protected]/proxy/5333
redirects tohttps://nebari.quansight.dev/user/[email protected]/proxy/5333/
Value and/or benefit
Users don't expect the closing slash to be meaningful, and users often waste several hours when facing this issue. This PR removes this potential issue for users by redirecting them.
What does this implement/fix?
Put a
x
in the boxes that applyTesting
Any other comments?