Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Continuously test pageserver http api with generated clients #1297

Closed
Tracked by #3676
LizardWizzard opened this issue Feb 18, 2022 · 2 comments
Closed
Tracked by #3676

Continuously test pageserver http api with generated clients #1297

LizardWizzard opened this issue Feb 18, 2022 · 2 comments
Labels
a/ci Area: related to continuous integration a/test Area: related to testing c/storage/pageserver Component: storage: pageserver

Comments

@LizardWizzard
Copy link
Contributor

It is possible for spec to diverge from the api, because we do not use generated clients for testing

see #1295
@LizardWizzard LizardWizzard self-assigned this Feb 18, 2022
@LizardWizzard LizardWizzard added c/storage/pageserver Component: storage: pageserver a/test Area: related to testing labels Feb 18, 2022
@kelvich
Copy link
Contributor

kelvich commented Feb 21, 2022

Actually console e2e tests do that -- now both e2e tests and console itself use generated clients. They just haven't use branching parts before.

But we can add (or even should) isolated API tests as well

@stepashka stepashka added the a/ci Area: related to continuous integration label Apr 21, 2022
@LizardWizzard LizardWizzard mentioned this issue Feb 27, 2023
Closed
2 tasks
@LizardWizzard
Copy link
Contributor Author

Last time we discussed this the intention was to move towards grpc for pageserver apis. This will lead to us using generated client for python api tests. For current state of things this is still a good idea for tests to use a client thats generated from swagger directly.

@LizardWizzard LizardWizzard removed their assignment Aug 14, 2023
@shanyp shanyp closed this as completed Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a/ci Area: related to continuous integration a/test Area: related to testing c/storage/pageserver Component: storage: pageserver
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kelvich @stepashka @shanyp @LizardWizzard