fix(command-deploy): remove random spinner #2576
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
Fixes #2086
Fixes #2557
After adding some debug logs, specifically logging the error here:
cli/src/utils/telemetry/tracked-command.js
Line 38 in fa7cd00
I was able to reproduce the issue and get the stacktrace for it. The offending code is here:
https://github.com/sindresorhus/ora/blob/c7d6dba4a723cfa640e6adb716cb6b5dad2c22d2/index.js#L249
frames
appears to beundefined
.The underlying issue is that the following line:
cli/src/commands/deploy.js
Line 6 in fa7cd00
adds
'default'
to thecliSpinnerNames
array and that is not a valid spinner name.Spinner names are validated here:
https://github.com/sindresorhus/ora/blob/c7d6dba4a723cfa640e6adb716cb6b5dad2c22d2/index.js#L171
but that code suffers from a similar bug of allowing
'default'
.I removed using a random spinner since it feels confusing anyway, however if we want to keep it we can simply use
spinner: 'random'
.- Test plan
Existing tests
- A picture of a cute animal (not mandatory but encouraged)
🐒