Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain envelope thread action on top right when switching between multiple threads #10720

Open
st3iny opened this issue Feb 18, 2025 · 0 comments
Labels
1. to develop enhancement skill:frontend Issues and PRs that require JavaScript/Vue/styling development skills

Comments

@st3iny
Copy link
Member

st3iny commented Feb 18, 2025

Is your feature request related to a problem? Please describe.

The actions on the top right are reloaded each time a new thread is opened. The problem is that the actions menu needs to calculate the available width first and then decide how many buttons it can inline.

Navigating to another thread causes a full re-render of the whole right pane which causes this recalculation to happen over and over again.

Describe the solution you'd like

The available horizontal space doesn't change when navigation between threads so the menu shouldn't need to recalculate which actions to put inline. It should not jump around or flicker each time I switch to another thread.

Describe alternatives you've considered

No response

Additional context

I'm not sure if the effort is worth it. The only way I could image, is to keep the thread header alive and only render the content inside via the router. This way, the thread header and actions would stay "static" and only the contents would be re-rendered each time. However, this would require extensive code changes as the route is currently replacing everything in the right pane on navigation.

Another way would be to hack the NcActions component and somehow cache the amount of inline actions if the screen's width did not change since last time.

@st3iny st3iny added the skill:frontend Issues and PRs that require JavaScript/Vue/styling development skills label Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop enhancement skill:frontend Issues and PRs that require JavaScript/Vue/styling development skills
Projects
None yet
Development

No branches or pull requests

1 participant