-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add shares to poll schema #3513
Conversation
Signed-off-by: dartcafe <[email protected]>
Signed-off-by: dartcafe <[email protected]>
Signed-off-by: dartcafe <[email protected]>
Signed-off-by: dartcafe <[email protected]>
Signed-off-by: dartcafe <[email protected]>
Signed-off-by: dartcafe <[email protected]>
Signed-off-by: dartcafe <[email protected]>
Signed-off-by: dartcafe <[email protected]>
Unfortunately there is no dbal method to get an abtraction but the syntax is different. Therefore the platforms have to be identified and individual seletcs are necessary. @ChristophWurst Is there anyone who can verify this on sqlite, postgre and oracle? The setup should be a poll with some groupshares. |
Signed-off-by: dartcafe <[email protected]>
Signed-off-by: dartcafe <[email protected]>
Signed-off-by: dartcafe <[email protected]>
A colleague is planning to look into that. It may make sense given #3503 is getting too complicated. |
Yes. @artonge already told me. I think it will be done with replacing the attributes with annotations or just add them and by removing the few incompatibilities you already found. BTW: This PR will get some more updates, mainly for the js part. |
Signed-off-by: dartcafe <[email protected]>
Signed-off-by: dartcafe <[email protected]>
Signed-off-by: dartcafe <[email protected]>
Signed-off-by: dartcafe <[email protected]>
Signed-off-by: dartcafe <[email protected]>
Signed-off-by: dartcafe <[email protected]>
Signed-off-by: dartcafe <[email protected]>
Signed-off-by: dartcafe <[email protected]>
Signed-off-by: dartcafe <[email protected]>
This reverts commit 2248edf.
Signed-off-by: dartcafe <[email protected]>
Signed-off-by: dartcafe <[email protected]>
Signed-off-by: dartcafe <[email protected]>
Signed-off-by: dartcafe <[email protected]>
Signed-off-by: dartcafe <[email protected]>
Signed-off-by: dartcafe <[email protected]>
@artonge merging, thisd PR is huge enough. Any further fixes will be done in individual PRs. |
What has changed with this PR?
The PR addresses a few aspects.
Loading polls was rather slow with a big amount of polls, since there were a lot of database requests, mainly for permission checks and when dealing with the acl.
The new approach loads all necessary informations for the permission checks from the database via subqueries and joins. This way, permissions can be checked directly inside the poll.
As a result the old usage of the Acl has been changed and the new Acl carries not any poll informations, but the user information based on the
UserSession
and the app permissions.In the result the structure of the API has changed for a better segmentation. The most important change is, that all changable properties are collected inside the
configuration
node of the json structure.The following vue3 migration will be done in two steps:
1. Migrating from vuex to pinia and typescript
2. The final migration to vue3 with the options API including updating the stores
3. Further rolling by-the-way migration of the options API to the composition API
@Bagoult FYI, since you are working with the API.
The structure layout is rather final, but may still get some updates in detail. Also the user objects will still receive some optimizations. I plan to get this API (v1.0) finalized.
To dos: