-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OC\Files\Stream\Encryption::loadContext($name) should be compatible with Icewind\Streams\Wrapper::loadContext #26464
Comments
This comment has been minimized.
This comment has been minimized.
The problem is that the method of the |
This also seems to happen on Nextcloud 21.0.1 |
@jknockaert You asked in #24966 to get tagged for this. 🙂 |
@jknockaert did you have anytime to look into this :) |
Yes. Error 3 is a duplicate of #26473. For the other two errors I can't yet make sense of it. I'd rather first have a better understanding of what we see happening in some other recent errors which may be wrapper related. |
Thank you! @jknockaert is there anything you need on my end ? more logs ? |
Are you actually using SMB storage for your files? |
Nope everything is local i dont use SMB storage |
OK let's keep this one open for now. |
Okay sounds good! |
@AndyXheli Today I decided to switch off encryption on my NC server, so I will no longer investigate any issues relating to its sloppy implementation. |
This comment has been minimized.
This comment has been minimized.
@vitormattos anyway you could help with this please? :) |
This issue is referenced as solution on NC's forum, though: I upgraded to NC 21.0.2 RC1 and the upload fails are still there:
|
Still an issue on Nextcloud 20.0.10 |
@juliushaertl @rullzer im really sorry to bother you I was just wondering do you have any feedback on this? |
Pushed a fix to icewind1991/Streams#15 |
I believe, that the base problem is that different Icewind/Streams implementations are available under ./3rdparty/icewind and ./apps/files_external/3rdparty/icewind, as i see in my 20.0.9 installation. In my former nextcloud version 19.0.9 the files under the 2 paths were equal (for nextcloud 19.0.9 with files_external app version 1.10.0) |
This is another problem. I have seen this also on a 20.0.10 version during file upload, but the files are ok afterwards.
the following code does a check after the key
|
icewind1991/Streams#15 dose fix the issue on NC 21 but not on NC 20.0.10. For more info please see icewind1991/Streams#15 |
the correct solution should be to clarify, which Icewind/Streams implementations either ./3rdparty/icewind/streams or ./apps/files_external/3rdparty/icewind/streams should be used. Different classes with the same namespaces should be avoided. Until the 20er version (i don't know which minor version has changed this) both Icewind/Streams paths are providing the same version. |
I have version 21.0.2.1 stable and I have the same error. Error: Undefined index: encryptedVersion at /var/www/html/lib/private/Files/Storage/Wrapper/Encryption.php#669
|
Issue fixed in 21.0.3 |
@vitormattos
Getting the followung error once updated to NC 20.0.9 everytime i open a file or scroll throw the photos app or files
Nextcloud Error 1 (data/nextcloud.log)
Error: Declaration of OC\Files\Stream\Encryption::wrapSource($source, $context, $protocol, $class, $mode = 'r+') should be compatible with Icewind\Streams\WrapperHandler::wrapSource($source, $context = Array, $protocol = NULL, $class = NULL) at /var/www/nextcloud/lib/private/Files/Stream/Encryption.php#201
Nextcloud Error 2 (data/nextcloud.log)
Error: Declaration of OC\Files\Stream\Encryption::loadContext($name) should be compatible with Icewind\Streams\Wrapper::loadContext($name = NULL) at /var/www/nextcloud/lib/private/Files/Stream/Encryption.php#224 --
The text was updated successfully, but these errors were encountered: