Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify Data Types #142

Open
benajamin opened this issue Sep 15, 2022 · 9 comments
Open

Clarify Data Types #142

benajamin opened this issue Sep 15, 2022 · 9 comments
Assignees
Labels
NIAC approved Proposal has been accepted by a NIAC vote

Comments

@benajamin
Copy link
Contributor

benajamin commented Sep 15, 2022

We have not specified precisely what NX_NUMBER incudes, e.g. does it include NX_QUATERNION?
Further, issue nexusformat/definitions#945 requires a data type that encompasses both NX_NUMBER and NX_CHAR.

@benajamin
Copy link
Contributor Author

benajamin commented Sep 15, 2022

Proposal is to define NX_CHAR_XOR_NUM which encompasses NX_NUMBER and NX_CHAR such that either type can be used exclusively for all elements of the entire dataset.

@benajamin
Copy link
Contributor Author

benajamin commented Sep 15, 2022

Proposal is to replace the description of NX_NUMBER in the NeXus manual with: "any of the set of non-compound number representations NX_INT, NX_UINT, NX_POSINT and NX_FLOAT."

@benajamin
Copy link
Contributor Author

and for completeness:
Proposal is to define NX_COMPOUND as encompassing the set of compound number types such as NX_COMPLEX, NX_CCOMPLEX, NX_PCOMPLEX and NX_QUATERNION

@benajamin benajamin self-assigned this Sep 15, 2022
@benajamin benajamin added the Ready for Vote Issue makes a clear proposal that the NIAC can vote on label Sep 15, 2022
@sanbrock sanbrock moved this to Voting in NIAC2022 project Sep 15, 2022
@prjemian
Copy link
Contributor

NX_NUMBER is not vague:

	<xs:simpleType name="NX_NUMBER">
		<xs:annotation>
			<xs:documentation>any valid NeXus number representation</xs:documentation>
		</xs:annotation>
		<xs:union memberTypes="
			nxdl:NX_INT 
			nxdl:NX_UINT 
			nxdl:NX_POSINT 
			nxdl:NX_FLOAT
			" />
	</xs:simpleType>

@FreddieAkeroyd
Copy link
Member

FreddieAkeroyd commented Sep 15, 2022

NX_ALPHANUM to me usually means a string of numbers and characters, how about NX_SIMPLETYPE ? or just NX_SIMPLE to complement NX_COMPOUND

@prjemian
Copy link
Contributor

simpleType is an XSD/XML thing, seems awkward

@prjemian
Copy link
Contributor

NX_CHAR_OR_NUM

@prjemian
Copy link
Contributor

NX_CHAR_XOR_NUM

@PeterC-DLS
Copy link

and for completeness: Proposal is to define NX_COMPOUND as encompassing the set of compound number types such as NX_COMPLEX, NX_CCOMPLEX, NX_PCOMPLEX and NX_QUATERNION

Rejected as a use-case cannot be forseen without including simple number types (i.e. NX_NUMBER).

@benajamin benajamin added NIAC approved Proposal has been accepted by a NIAC vote and removed Ready for Vote Issue makes a clear proposal that the NIAC can vote on labels Sep 15, 2022
@benajamin benajamin moved this from Voting to Done in NIAC2022 project Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NIAC approved Proposal has been accepted by a NIAC vote
Projects
No open projects
Status: Done
Development

No branches or pull requests

4 participants