Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

additions to NXsource #1459

Closed
sanbrock opened this issue Sep 26, 2024 · 2 comments · Fixed by #1407
Closed

additions to NXsource #1459

sanbrock opened this issue Sep 26, 2024 · 2 comments · Fixed by #1407

Comments

@sanbrock
Copy link
Contributor

#1407
@sanbrock sanbrock converted this from a draft issue Sep 26, 2024
@sanbrock
Copy link
Contributor Author

PR #1407

@lukaspie lukaspie linked a pull request Sep 29, 2024 that will close this issue
FAIRmat 2024: small additions to NXsource #1407
Merged
@sanbrock
Copy link
Contributor Author

sanbrock commented Sep 29, 2024 •
edited by lukaspie
Loading

Proposal:

  • NXsource
    • added new types to enum list, like LED, Laser, etc. with the possibility to specify type_other
    • added new probe to enum list: photon
    • added new fields: FABRICATION, wavelength, pulse_energy, peak_power,
    • anode_material, filament_current, emission_current, gas_pressure,
    • previous_source, APERTURE, DEFLECTOR, LENS_EM
      A) accept proposal as is
      B) use subclassing

@lukaspie lukaspie changed the title NXsource additions to NXsource Dec 6, 2024
@github-project-automation github-project-automation bot moved this from To finish after the meeting to Done in NIAC 2024 project Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
NIAC 2024 project
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FAIRmat 2024: small additions to NXsource FAIRmat-NFDI/nexus_definitions
1 participant
@sanbrock