You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Black, flake8, and isort are not pinned in the requirement.txt file, but rather lower bound. This can lead to issues with the Github CI/CD (that internally runs make style), meaning that changes to the dev_tools code need to mixed in with changes to the definitions. The easiest solution is to pin these dependencies explicitly and update their versions in the requirement.txt from time to time.
The text was updated successfully, but these errors were encountered:
What about ruff instead of black, flake8, and isort? The web page describes advantages. One relevant advantage here is the ability to define expected behavior in a configuration file.
We have been using ruff and its pre-commithook across our codebase a lot, it's great. If you want, I can set it up here / sent you to the relevant setup that we are using. But, ruff is also actively being developed and new linting rules are added continously, so you have the same issue with pinning a version as with the other tools.
See comments in #1413 (comment) and #1536.
Black, flake8, and isort are not pinned in the
requirement.txt
file, but rather lower bound. This can lead to issues with the Github CI/CD (that internally runsmake style
), meaning that changes to thedev_tools
code need to mixed in with changes to the definitions. The easiest solution is to pin these dependencies explicitly and update their versions in therequirement.txt
from time to time.The text was updated successfully, but these errors were encountered: