Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRLF line endings reported by jenkins workflow #965

Closed
prjemian opened this issue Dec 17, 2021 · 2 comments · Fixed by #1051
Closed

CRLF line endings reported by jenkins workflow #965

prjemian opened this issue Dec 17, 2021 · 2 comments · Fixed by #1051
Assignees
Labels
Milestone

Comments

@prjemian
Copy link
Contributor

Is this a problem we should resolve?

+ git add .
warning: CRLF will be replaced by LF in _downloads/0a877a94f6f32b982b9a0c74073f6f01/write_nexus_file2.py.
The file will have its original line endings in your working directory
warning: CRLF will be replaced by LF in _downloads/464bd71626b8a660aadb9fc6cb05ae82/FDL.
The file will have its original line endings in your working directory
warning: CRLF will be replaced by LF in _downloads/dfc22f4a37f3414e5e8cc7135510b802/write_nexus_file.py.
The file will have its original line endings in your working directory
warning: CRLF will be replaced by LF in examples/epics/tree_structure.txt.
The file will have its original line endings in your working directory
warning: CRLF will be replaced by LF in examples/epics/write_nexus_file.py.
The file will have its original line endings in your working directory
warning: CRLF will be replaced by LF in examples/epics/write_nexus_file2.py.
The file will have its original line endings in your working directory
warning: CRLF will be replaced by LF in examples/napi-java-jnexus.bat.
The file will have its original line endings in your working directory
@prjemian
Copy link
Contributor Author

Also related to #964

@PeterC-DLS
Copy link
Contributor

PeterC-DLS commented Jun 13, 2022

Using

find . -not -type d -exec file "{}" \; | grep CRLF

in repo gives

./manual/source/FDL: ASCII text, with CRLF line terminators
./manual/source/examples/epics/write_nexus_file2.py: ASCII text, with CRLF line terminators
./manual/source/examples/epics/write_nexus_file.py: Python script, ASCII text executable, with CRLF line terminators
./manual/source/examples/epics/tree_structure.txt: ASCII text, with CRLF line terminators
./manual/source/examples/napi-java-jnexus.bat: ASCII text, with CRLF line terminators

I will convert those apart from the .bat file.

PeterC-DLS added a commit that referenced this issue Jun 13, 2022
…#965

Add .gitattributes to add .bat as special case of DOS line ending
PeterC-DLS added a commit that referenced this issue Jun 13, 2022
…#965

Add .gitattributes to add .bat as special case of DOS line ending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants