Deprecate incr attribute of dimension type #1020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove from NXfilter's coating_roughness field (which was add in 20090304 by change f86bdcb)
|
Needs reviewing @mkoennecke, @prjemian, @benajamin |
benajamin
approved these changes
Jun 15, 2022
There was a problem hiding this comment.
LTGM
I did a search and found that @incr is also used in manual/source/examples/array-dimensions.xml.txt but I don't think that file is actually referenced for inclusion in the manual. I will make a new issue about removing unreferenced files from the manual source.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove from NXfilter's coating_roughness field (which was add in 20090304 by change f86bdcb)