Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NX_COMPLEX - Update nxdlTypes.xsd #1068

Merged
merged 8 commits into from
Jun 15, 2022
Merged

NX_COMPLEX - Update nxdlTypes.xsd #1068

merged 8 commits into from
Jun 15, 2022

Conversation

sanbrock
Copy link
Contributor

@sanbrock sanbrock commented Jun 13, 2022

added NX_CCOMPLEX, NX_PCOMPLEX. NX_COMPLEX, and NX_QUATERNION

added NX_CCOMPLEX, NX_PCOMPLEX. NX_COMPLEX, and NX_QUATERNION
@sanbrock sanbrock added this to the NXDL 2022.06 milestone Jun 13, 2022
@sanbrock sanbrock self-assigned this Jun 13, 2022
@sanbrock sanbrock changed the title Update nxdlTypes.xsd NX_COMPLEX - Update nxdlTypes.xsd Jun 13, 2022
@mkuehbach
Copy link
Contributor

xs:documentation have a typo in all four data types: should be "representation" instead of "representaion"

@prjemian prjemian requested a review from PeterC-DLS June 13, 2022 23:22
@prjemian
Copy link
Contributor

@PeterC-DLS This is ready for review.

@prjemian
Copy link
Contributor

View of published documentation:
Clipboard01

@sanbrock
Copy link
Contributor Author

NX_COMPLEX types are now represented as LIST of 2 doubles (in case of quaternions, 4 doubles). Trying to describe them as a proper compound type with labels, like 'r' for the real part and 'i' for the imaginary, one should define a SEQUENCE instead of a list.
This requires the creation and use of ComplexTypes instead of SimpleTypes for our 'primitiveTypes'. Unfortunately, complexTypes are not supported to specify the TYPE of an ATTRIBUTE which we need for defining the NXDL attribute 'type':
https://github.com/nexusformat/definitions/blob/1056-NX_COMPLEX/nxdl.xsd?#L764

Copy link
Contributor

@PeterC-DLS PeterC-DLS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prjemian
Copy link
Contributor

@PeterC-DLS Thanks for the review!

@sanbrock Merge when you are ready.

@sanbrock sanbrock merged commit 2bb99a4 into main Jun 15, 2022
@sanbrock sanbrock deleted the 1056-NX_COMPLEX branch June 15, 2022 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NX_COMPLEX (a new Nexus type for complex numbers) NX_COMPLEX: a new NeXus data type for complex numbers
4 participants