-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NX_COMPLEX - Update nxdlTypes.xsd #1068
Conversation
added NX_CCOMPLEX, NX_PCOMPLEX. NX_COMPLEX, and NX_QUATERNION
xs:documentation have a typo in all four data types: should be "representation" instead of "representaion" |
@PeterC-DLS This is ready for review. |
NX_COMPLEX types are now represented as LIST of 2 doubles (in case of quaternions, 4 doubles). Trying to describe them as a proper compound type with labels, like 'r' for the real part and 'i' for the imaginary, one should define a SEQUENCE instead of a list. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@PeterC-DLS Thanks for the review! @sanbrock Merge when you are ready. |
added NX_CCOMPLEX, NX_PCOMPLEX. NX_COMPLEX, and NX_QUATERNION