-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add NeXus Constructor and nxdl_to_hdf5.py #1085
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@RussBerg Please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @prjemian can you replace the lines for nxdl_to_hdf5.py with these?:
nxdl_to_hdf5.py is a python script that reads the NeXus definition files (i.e. nxdl.xml) and creates example python scripts as well as hdf5 files for each definition. There are generated example scripts of each application definition for both h5py
and nexusformat
. Currently, only application definitions and some contributed_definitions are supported as the code depends on the existence of an NXentry in the definition.
@RussBerg please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great thanks
fixes #972