Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add NeXus Constructor and nxdl_to_hdf5.py #1085

Merged
merged 2 commits into from
Jun 15, 2022
Merged

add NeXus Constructor and nxdl_to_hdf5.py #1085

merged 2 commits into from
Jun 15, 2022

Conversation

benajamin
Copy link
Contributor

fixes #972

@prjemian prjemian added this to the NXDL 2022.06 milestone Jun 14, 2022
@benajamin benajamin self-assigned this Jun 14, 2022
@benajamin benajamin requested review from prjemian and RussBerg June 14, 2022 14:20
Copy link
Contributor

@prjemian prjemian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prjemian
Copy link
Contributor

@RussBerg Please review

Copy link
Contributor

@RussBerg RussBerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @prjemian can you replace the lines for nxdl_to_hdf5.py with these?:

nxdl_to_hdf5.py is a python script that reads the NeXus definition files (i.e. nxdl.xml) and creates example python scripts as well as hdf5 files for each definition. There are generated example scripts of each application definition for both h5py and nexusformat. Currently, only application definitions and some contributed_definitions are supported as the code depends on the existence of an NXentry in the definition.

@prjemian prjemian requested a review from RussBerg June 15, 2022 20:06
@prjemian
Copy link
Contributor

@RussBerg please review

Copy link
Contributor

@RussBerg RussBerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great thanks

@prjemian prjemian merged commit 918df5e into main Jun 15, 2022
@prjemian prjemian deleted the 972-add-utilities branch June 15, 2022 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NeXus Constructor and other utilities
3 participants