Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove duplicate group from NXpinhole #1106

Merged
merged 1 commit into from
Jun 17, 2022
Merged

remove duplicate group from NXpinhole #1106

merged 1 commit into from
Jun 17, 2022

Conversation

woutdenolf
Copy link
Contributor

Closes #1105

@woutdenolf woutdenolf requested review from prjemian and phyy-nx June 17, 2022 11:31
@woutdenolf woutdenolf self-assigned this Jun 17, 2022
@woutdenolf woutdenolf added this to the NXDL 2022.06 milestone Jun 17, 2022
PeterC-DLS
PeterC-DLS approved these changes Jun 17, 2022
View reviewed changes
Copy link
Contributor

@PeterC-DLS PeterC-DLS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@woutdenolf woutdenolf merged commit c1c6e42 into main Jun 17, 2022
@prjemian prjemian deleted the 1105-nxpinhole-sphinx-warning branch June 23, 2022 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterC-DLS PeterC-DLS PeterC-DLS approved these changes

@prjemian prjemian Awaiting requested review from prjemian

@phyy-nx phyy-nx Awaiting requested review from phyy-nx

Assignees

@woutdenolf woutdenolf

Labels
bug code camp documentation
Projects
None yet
Milestone
NXDL 2022.06
Development

Successfully merging this pull request may close these issues.

nxpinhole sphinx warning
2 participants
@woutdenolf @PeterC-DLS