Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table of Hypertext Anchors just needs first column #1114

Merged
merged 1 commit into from
Jun 20, 2022

Conversation

prjemian
Copy link
Contributor

Copy link
Contributor

@woutdenolf woutdenolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

For reference, it looks like this now:
image

@prjemian prjemian merged commit 119e5c7 into main Jun 20, 2022
@prjemian prjemian deleted the 1108-list-hypertext-anchors branch June 20, 2022 14:43
Copy link
Contributor

@PeterC-DLS PeterC-DLS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is the only place that used pyRestTable then can remove it as a dependency from package

@prjemian
Copy link
Contributor Author

still in utils/nxdl2rst.py:

(bluesky_2022_2) prjemian@zap:~/.../NeXus/definitions$ git checkout main
Already on 'main'
Your branch is up to date with 'origin/main'.
(bluesky_2022_2) prjemian@zap:~/.../NeXus/definitions$ git pull
Already up to date.
(bluesky_2022_2) prjemian@zap:~/.../NeXus/definitions$ git grep -i pyresttable
.github/env-workflow.yml:  - pyRestTable
requirements.txt:pyRestTable
utils/nxdl2rst.py:import pyRestTable

@woutdenolf
Copy link
Contributor

pyRestTable is imported but not actually used.

@PeterC-DLS
Copy link
Contributor

Pete, you removed the only user (previous line 45 onwards) in this PR.

@prjemian
Copy link
Contributor Author

Ok, will remove the pyRestTable requirement, as you said. And the one unused import.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nxdl2rst.py: Table of Hypertext Anchors just needs first column
3 participants