-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce developer tools to replace the util scripts #1133
Conversation
b3a7945
to
aa9ca3b
Compare
64a7127
to
b7fa250
Compare
Just noticed Yep, |
I'll fix it. Edit: wait I though I fixed that ... was it not merged? Edit: ah there is a second place where Edit: related issue #1155 (I'm working on it) |
Can check |
Rebased on |
Currently the difference with the main branch: diff.log
|
Without the
Looks good to me. |
Captures my attention: 28c28
< see: attribute; NXDL attribute
---
> see:attribute; NXDL attribute Is this deleted whitespace important to Sphinx? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done a comparison with main
and only differences are timestamps and auto-generated. Good work on the massive speed-up, Wout!
Most of the differences I see are due to trailing white space. Purely cosmetic. |
|
By my unscientific measure, about 15x faster! |
I pushed the big green button. |
Hmmm I wonder. I didn't catch that. |
Locally, built the documentation. It's OK in the index under "attribute", among other items, says see NXDL attribute. |
I don't think it matters: https://www.sphinx-doc.org/en/master/usage/restructuredtext/directives.html#directive-index |
Good to release then with 208 items closed in the milestone! |
Thanks for the help with validation. It's a big change but the speed-up and easier maintenance in the future is worth it imo. |
That was a great collaboration, y'all. The end product was much stronger for all our contributions. Not to rain on anyone's parade but we have one necessary step before making the release: |
Closes #1144 #1131
Currently: apart from the actual
sphinx
building we have some scripts inutils
which in combination withmake
files and some custom stuff in the github workflows prepare the files for asphinx
build.In this PR I propose a python based CLI to do all the non-
sphinx
stuffhttps://github.com/woutdenolf/definitions/blob/dev_tools/dev_tools/README.md
Benefits:
utils
for an out-of-source buildpytest
to minimize test code (unittest
has lots of boilerplate)The python scripts in
utils
directory become obsolete:build_preparation.py
:python3 -m dev_tools manual --prepare
(prepare sphinx build)nxdl2rst.py
:python3 -m dev_tools manual --prepare
(prepare sphinx build)dev_nxdl2rst.py
:python3 -m dev_tools nxclass nxfluo --print
(for development)test_nxdl.py
:pytest dev_tools
(for testing)test_nxdl2rst.py
:pytest dev_tools
(for testing)test_suite.py
:pytest dev_tools
(for testing)nxdl_desc2rst.py
:python3 -m dev_tools manual --prepare
(prepare sphinx build)nxdl_summary.py
:python3 -m dev_tools manual --prepare
(prepare sphinx build)types2rst.py
:python3 -m dev_tools manual --prepare
(prepare sphinx build)units2rst.py
:python3 -m dev_tools manual --prepare
(prepare sphinx build)dev_units2rst.py
:local_utilities.py
:Not included (could be but not in this PR)
create_release_notes.py
dev_create_release_notes.py
update_copyright_date.py
To show the difference with
make local
: