Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_punx target already exists #1138

Merged
merged 1 commit into from
Jun 26, 2022
Merged

_punx target already exists #1138

merged 1 commit into from
Jun 26, 2022

Conversation

woutdenolf
Copy link
Contributor

@woutdenolf woutdenolf commented Jun 26, 2022 •
edited
Loading

@woutdenolf woutdenolf requested a review from prjemian June 26, 2022 07:52
prjemian
prjemian approved these changes Jun 26, 2022
View reviewed changes
Copy link
Contributor

@prjemian prjemian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@woutdenolf
Copy link
Contributor Author

woutdenolf commented Jun 26, 2022 •
edited
Loading

I noticed when running the doc build with the -W option. Another thing I introduced in #1133.

I also found #1139. For that one I did not let failing latex builds go through with ($(MAKE) latexpdf LATEXOPTS="--interaction=nonstopmode -f" -C manual || exit 0).

Warnings are there for a reason. The sphinx>=5 requirement in #1139 makes sure we can actually do this. Also there is no reason anymore to run the pdf build twice with a manual in index build in between.

@woutdenolf woutdenolf merged commit 9a7b5ee into nexusformat:main Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prjemian prjemian prjemian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@woutdenolf @prjemian