Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renames relative_molecular_mass #564

Closed
wants to merge 1 commit into from

Conversation

mtwharmby
Copy link
Contributor

relative_molecular_mass was carried over from the contributed
definition NXcontainer. For consistency with the chemical_formula field
and also with (e.g.) the CIF definitions, it should be renamed
chemical_formula_weight.

This was discussed (some time ago) with @markbasham

Signed-off-by: Michael Wharmby [email protected]

relative_molecular_mass was carried over from the contributed 
definition NXcontainer. For consistency with the chemical_formula field
and also with (e.g.) the CIF definitions, it should be renamed 
chemical_formula_weight.

Signed-off-by: Michael Wharmby <[email protected]>
@prjemian prjemian added the telco label Jul 18, 2017
@prjemian
Copy link
Contributor

Added to 2017-07-25 telco that this PR will be merged unless there are objections raised.

@prjemian prjemian added this to the NXDL 3.4 milestone Jul 18, 2017
@zjttoefs
Copy link
Contributor

relative_molecular_mass is the historical NeXus term and I see no reason to change that by the way of a pull request, especially since the field was only re-confirmed in NXsample_component last October.

@zjttoefs zjttoefs closed this Jul 18, 2017
@mtwharmby
Copy link
Contributor Author

Rather than closing, might it not be worth discussing?
As a reason to change the name: consistency with other fields in NeXus (e.g. chemical_formula) and also with CIF format. Also by having similar names, when looking at the NeXus tree, chemical_formula and chemical_formula_mass/weight appear together, which helps readability.

Also, the last time I heard anyone use the term relative_molecular_mass was in a high school science text book (though searching the web, hit number five on Google is the IUPAC gold book)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants