Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some references to NAPI for #699 #722

Merged
merged 2 commits into from
Jan 23, 2020
Merged

Conversation

PeterC-DLS
Copy link
Contributor

@PeterC-DLS PeterC-DLS commented Jan 23, 2020

Refs #699
Remove alias in schema, add links to schema documentation,
unescape HTML tags in doc generator

Remove alias in schema, add links to schema documentation,
unescape HTML tags in doc generator
Copy link
Contributor

@prjemian prjemian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change as previously noted. This does not fully resolve #699, correct?

Copy link
Contributor Author

@PeterC-DLS PeterC-DLS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change as previously noted. This does not fully resolve #699, correct?

Yes, I reviewed other mentions of NAPI and they are pertinent to that.

Copy link
Contributor

@benajamin benajamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine.

@prjemian prjemian merged commit 47f8ddf into master Jan 23, 2020
@prjemian prjemian deleted the remove-napi-references branch January 23, 2020 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants