From code camp, add note to NXmx that file_name and file_time are recommended #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prjemian
reviewed
Jan 28, 2020
prjemian
reviewed
Jan 28, 2020
|
I'm marking this for the milestone this week. If it's not resolved by COB Thursday, I'll move it to the next milestone. |
|
Addressed comments. Thanks. I'll merge this on Thursday unless there are objections. |
prjemian
reviewed
Jan 30, 2020
applications/NXmx.nxdl.xml
Outdated
| @@ -62,8 +62,9 @@ | |||
| <group type="NXentry"> | |||
|
|
|||
| <doc> | |||
| Note, it is recommended that file_name and file_time are included as fields | |||
| at the root of a file that includes NXmx. See :ref:`NXroot`. | |||
| Note, it is recommended that file_name and file_time are included as | |||
|
@prjemian ok to merge? |
prjemian
approved these changes
Jan 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also nexusformat/cnxvalidate#24