-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
repair workflow and make Python code compliant with py3 #951
Conversation
prjemian
commented
Dec 9, 2021
- FIX documentation build requires python2 #946
- FIX The workflow is failing, even when restarted. #950
Now, with #946 and #950 repaired, the workflow log shows there is an indentation error in the 51 use XML entity
The code is now having troubles resolving and removing the indentation of the embedded rst documentation. Time to refactor to |
Also, this code |
@PeterC-DLS : please review The workflow is now successful, after fixing the environment file and replacing our/my complicated (and failing) Python code that removes common indentation with similar capability from the Python standard library package @zjttoefs : please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Tried it locally and it was able to generate everything using python 3.9. Dropping support for 2.x Python makes sense.
@PeterC-DLS @zjttoefs : Thanks for the quick response! |