Adding depends on #999
Closed
Adding depends on #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* done this where possible (with reference drawings) * added some more geometry related information * deprecated old-style geometry * minor adjustments
|
According to https://www.nexusformat.org/NIAC2022_spring.html#minutes and nexusformat/NIAC#109 (comment) this is approved. |
|
Is this a duplicate of #897? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
depends_onway of defining the location of an instrument component works well. But in some cases the proper reference location that is placed by thedepends_onis not well defined or obvious.This pull request mainly aims to rectify this.
depends_onhas been added to all base classes that would benefit from a well defined location. (NXnotewould not, for example.)In cases where we felt we could define the reference location, we have done so. With drawings in most cases.
Some base classes call for expert input what the reference location to place would be. TODO markers have been added.
If the preference would be to leave those classes untouched, that would mask an issue, but be acceptable to us.
OFF geometry shapes can be used to make the location unambiguous. For that reason they have been added. To keep the changeset small those edits could be deferred. Same for the explicit addition of NXtransformations.
In addition NXgeometry has been declared deprecated. Again, if this is not desired or does not reflect reality this does not have to happen as part of this PR.
The addition of the depends_on locations is a valuable tie breaker, though, and I would be thankful if that could be considered carefully.