Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rundeepvariant and vcfstatsreport #7301

Merged
merged 4 commits into from
Jan 17, 2025

Conversation

fellen31
Copy link
Contributor

@fellen31 fellen31 commented Jan 14, 2025

This PR bumps the deepvariant/rundeepvariant and deepvariant/vcfstatsreport modules.

I tried updating all modules at first (#7171), but this update comes with changes to the deepvariant subworkflow, changes that might outweigh the burden of maintaining three modules and a subworkflow in the first place. These two modules are outside of the subworkflow.

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@fellen31 fellen31 marked this pull request as ready for review January 16, 2025 08:16
@fellen31 fellen31 requested a review from edmundmiller January 16, 2025 08:16
@maxulysse maxulysse added this pull request to the merge queue Jan 17, 2025
Merged via the queue into nf-core:master with commit e9b59c8 Jan 17, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants