Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint for correct publishDir specification in modules.config #1286

Open
drpatelh opened this issue Oct 11, 2021 · 0 comments
Open

Lint for correct publishDir specification in modules.config #1286

drpatelh opened this issue Oct 11, 2021 · 0 comments
Labels
linting modules Related to tools for working with DSL2 modules

Comments

@drpatelh
Copy link
Member

There are various ways you can use the publishDIr directive in the native DSL2 implementation. One can only replace the entire publishDir directive which leads to a lot of repeated code in this config file. Along with checking if one of enabled: false, pattern: "<pattern>", or saveAs: { filename -> filename.equals('versions.yml') ? null : filename } is present (and that needs to account for the nested syntax too), otherwise the versions.yml gets output too.

Not sure how trivial it would be to lint for stuff like this...from what I have seen these directives can be used in loads of different ways so it is going to be a nightmare writing a parser for this. Also, NF configs aren't standard JSON / YAML we can just slurp up. I am not 💯 about having a custom function given that we have removed the need for almost all of them now but we do need to find a way to make these publishDir specifications clearer.

See nf-core/rnaseq#701 (comment)

@ewels ewels added modules Related to tools for working with DSL2 modules and removed DSL2 v2.0 labels Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linting modules Related to tools for working with DSL2 modules
Projects
None yet
Development

No branches or pull requests

2 participants