Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have nf-core lint check for cookiecutter statements in code and docs #564

Closed
maxulysse opened this issue Feb 28, 2020 · 2 comments · Fixed by #568
Closed

Have nf-core lint check for cookiecutter statements in code and docs #564

maxulysse opened this issue Feb 28, 2020 · 2 comments · Fixed by #568
Labels
linting

Comments

@maxulysse
Copy link
Member

I have no idea why, or how, but I got some cookiecutter statements in the sarek code.
cf nf-core/sarek#131
I'm guessing more a bad copy-paste rather than a faulty template update.
So not sure if it'll be really useful, but it could be good to check for cookiecutter statements in code and docs
@ewels ewels added the linting label Feb 28, 2020
@ewels
Copy link
Member

ewels commented Feb 28, 2020

Good idea - should be as simple as just searching for the string cookiecutter in all pipeline files I guess 👍

@ewels ewels mentioned this issue Feb 28, 2020
Merged
4 tasks
@ewels ewels linked a pull request Feb 28, 2020 that will close this issue
Add new lint test for cookiecutter strings #568
Merged
4 tasks
@drpatelh
Copy link
Member

drpatelh commented Mar 1, 2020

Fixed in linked PRs above.

@drpatelh drpatelh closed this as completed Mar 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
linting
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add new lint test for cookiecutter strings ewels/nf-core-tools
3 participants
@ewels @maxulysse @drpatelh